#9392 closed defect (fixed)
Broken docstring in binpacking method
Reported by: | ncohen | Owned by: | jason, jkantor |
---|---|---|---|
Priority: | major | Milestone: | sage-4.5 |
Component: | numerical | Keywords: | |
Cc: | rlm, leif | Merged in: | sage-4.5.alpha3 |
Authors: | Nathann Cohen | Reviewers: | Leif Leonhardy, Robert Miller |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Not really broken, but subject to change of behaviours depending on the solver used.... ;-)
Nathann
Attachments (2)
Change History (12)
Changed 9 years ago by
comment:1 Changed 9 years ago by
- Status changed from new to needs_review
comment:2 Changed 9 years ago by
- Cc leif added
comment:3 Changed 9 years ago by
- Status changed from needs_review to needs_work
Nathann's patch fails on normal (non-optional) doctesting because of undefined variables/some sections not marked "optional".
comment:4 Changed 9 years ago by
- Status changed from needs_work to needs_review
With my reviewer patch applied, at least passes reasonable tests (-long
, -long
with -only-optional=cbc,glpk
in sage/numerical
) on a 32-bit system where the doctest previously did not fail...
Leaving as "needs review" for further testing.
comment:5 Changed 9 years ago by
- Reviewers set to Leif Leonhardy, Robert Miller
Doesn't this depend on #9312?
comment:6 Changed 9 years ago by
Not really... Though if we say it depends on #9312, then we do not need to add these "optional" flags anymore :-D
Nathann
comment:7 Changed 9 years ago by
- Status changed from needs_review to positive_review
comment:8 Changed 9 years ago by
- Merged in set to sage-4.5.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
comment:9 follow-up: ↓ 10 Changed 9 years ago by
Well, if GLPK gets a standard package, we should definitely remove the optional
tags, since otherwise these tests are omitted in the usual test process.
(We could just substitute optional
by standard
to make life easier in case the package is made optional again for some reason. Same for Nathann's patch at #9312.)
Here it is !
Nathann