Changes between Initial Version and Version 1 of Ticket #9386, comment 28
 Timestamp:
 05/08/15 09:44:42 (7 years ago)
Legend:
 Unmodified
 Added
 Removed
 Modified

Ticket #9386, comment 28
initial v1 3 3 There's also a wild mixture of bash constructs and nonbash constructs, such as `(( $# > 1 ))` instead of `[ $# gt 1 ]`, while on the other hand e.g. `[ z ... ]` is used instead of `[[ z ... ]]` (the latter is btw. safe w.r.t. zero arguments / empty variables). 4 4 5 In `[ "x$SAGE_ENVIRONMENT_VARIABLES" == "x${SAGE_ENVIRONMENT_VARIABLES/$varname}" ]`, using both "x" and quoting is superfluous (and won't work if the variable name is "x"), `[[ $SAGE_ENVIRONMENT_VARIABLES = ${SAGE_ENVIRONMENT_VARIABLES/$varname} ]]` would suffice.5 In `[ "x$SAGE_ENVIRONMENT_VARIABLES" == "x${SAGE_ENVIRONMENT_VARIABLES/$varname}" ]`, using both "x" and quoting is superfluous , `[[ $SAGE_ENVIRONMENT_VARIABLES = ${SAGE_ENVIRONMENT_VARIABLES/$varname} ]]` would suffice. 6 6 7 But more importantly .that check does not at all work with variable names like `CXX` and `CXXFLAGS`, i.e., when one name is a substring of other variable names.7 But more importantly, that check does not at all work with variable names like `CXX` and `CXXFLAGS`, i.e., when one name is a substring of other variable names. 8 8