Opened 9 years ago

Closed 9 years ago

#9355 closed defect (fixed)

100% coverage for quadratic_forms

Reported by: annahaensch Owned by: mvngu
Priority: major Milestone: sage-4.5.2
Component: documentation Keywords: quadratic forms
Cc: Merged in: sage-4.5.2.alpha0
Authors: Anna Haensch Reviewers: David Loeffler
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description


Attachments (2)

trac_9355.patch (1.4 KB) - added by annahaensch 9 years ago.
trac_9355_loads_dumps.patch (1.7 KB) - added by annahaensch 9 years ago.
Apply on top of trac_9355.patch

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by annahaensch

comment:1 Changed 9 years ago by annahaensch

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by davidloeffler

  • Reviewers set to David Loeffler
  • Status changed from needs_review to needs_work
  • Work issues set to loads/dumps doctests

I tried this, and it is fine as far as it goes but sage -coverage still grumbles about the lack of a TestSuite.run() doctest in genera/genus.py. In fact the two classes in that file don't derive from SageObject? (although they probably should), so the TestSuite? machinery doesn't work on them; but it would be good to have loads/dumps doctests for these classes. With those added I would be happy for this to go in.

(A much bigger step forward would be adding the quadratic forms code to the reference manual, but that's a separate issue.)

Changed 9 years ago by annahaensch

Apply on top of trac_9355.patch

comment:3 Changed 9 years ago by annahaensch

  • Status changed from needs_work to needs_review

comment:4 Changed 9 years ago by davidloeffler

  • Status changed from needs_review to positive_review

OK, that looks fine.

comment:5 Changed 9 years ago by davidloeffler

  • Keywords quadratic forms added
  • Work issues loads/dumps doctests deleted

comment:6 Changed 9 years ago by mpatel

  • Merged in set to sage-4.5.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.