Opened 9 years ago

Closed 8 years ago

#9333 closed defect (fixed)

the kash optional spkg doesn't work at all on OS X due to mistake in use of tar

Reported by: was Owned by: tbd
Priority: minor Milestone: sage-4.7.1
Component: packages: optional Keywords:
Cc: Merged in: sage-4.7.1.alpha4
Authors: John Palmieri Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jhpalmieri)

Here's a new spkg:

This installs for me on sage.math and on an OS X box.


Apply:

Attachments (2)

trac_9333-kash-tar.patch (1.3 KB) - added by jhpalmieri 9 years ago.
for reference only; do not apply
trac_9333-kash-sage-library.patch (606 bytes) - added by jhpalmieri 9 years ago.
patch for sage library

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by jhpalmieri

for reference only; do not apply

comment:1 Changed 9 years ago by jhpalmieri

  • Authors set to John Palmieri
  • Description modified (diff)
  • Status changed from new to needs_review

I've posted a link to a new spkg, along with the patch used to create it. I have a feeling that it could use more work, but since it's an optional package for software which is 3 years old, I'm not sure if it's worth it. I also have a feeling that it shouldn't be an optional package, but rather an experimental one: since it only installs on OS X and linux, that's not enough platforms for a good optional package. But that change should be discussed elsewhere...

comment:2 Changed 9 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_review to needs_work

It even works on PPC!

I did find an error in kash.py

sage: a = kash('(9 - 7) * (5 + 6)'); a              # optional -- kash

22

so I get "expected nothing" for that one test when I do ./sage -t -optional devel/sage/sage/interfaces/kash.py.

Otherwise seems like this is reasonable. Fix that and positive review, modulo my weak understanding of shell script - but the options are the right ones on Mac. What the heck are those Linux options?

By the way, the development of KASH seems to have abruptly stopped. Any chance it will resume?

Changed 9 years ago by jhpalmieri

patch for sage library

comment:3 Changed 9 years ago by jhpalmieri

  • Status changed from needs_work to needs_review

Removing the blank line fixes the doctest for me. (I have no idea what the linux options are, by the way.)

comment:4 Changed 9 years ago by jhpalmieri

  • Description modified (diff)

comment:5 Changed 9 years ago by kcrisman

  • Status changed from needs_review to positive_review

Thumbs up.

comment:6 follow-up: Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.7.1.alpha4

Sage patch merged in sage-4.7.1.alpha4 but the "optional packages" page needs to be updated manually. John, can you take care of this?

comment:7 in reply to: ↑ 6 Changed 8 years ago by jhpalmieri

Replying to jdemeyer:

Sage patch merged in sage-4.7.1.alpha4 but the "optional packages" page needs to be updated manually. John, can you take care of this?

Okay, done.

comment:8 Changed 8 years ago by jdemeyer

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.