Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#9323 closed defect (fixed)

Remove devel/sage/doc/en/faq/Makefile

Reported by: was Owned by: mvngu
Priority: minor Milestone: sage-4.5
Component: documentation Keywords:
Cc: Merged in: sage-4.5.alpha1
Authors: Robert Miller Reviewers: Minh Van Nguyen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Why? 'cause Mike Hansen says so.

Change History (10)

comment:1 Changed 9 years ago by mvngu

  • Status changed from new to needs_review

It is removed in Sage 4.4.4:

[mvngu@sage faq]$ pwd
/dev/shm/mvngu/sandbox/sage-4.4.4/devel/sage-main/doc/en/faq
[mvngu@sage faq]$ hg st
! doc/en/faq/Makefile

This has not effect on building the HTML or PDF versions of the FAQ. Both of these versions build fine. The release manager can close this ticket as fixed.

comment:2 Changed 9 years ago by mvngu

  • Status changed from needs_review to positive_review

comment:3 Changed 9 years ago by mpatel

  • Milestone changed from sage-4.5.2 to sage-duplicate/invalid/wontfix
  • Resolution set to fixed
  • Status changed from positive_review to closed

It appears that someone has already removed the FAQ Makefile.

comment:4 follow-up: Changed 9 years ago by mpatel

Just to check: Should we keep doc/en/tutorial/Makefile?

comment:5 follow-up: Changed 9 years ago by mpatel

Minh, should I select a different resolution and/or milestone?

comment:6 in reply to: ↑ 5 Changed 9 years ago by mvngu

Replying to mpatel:

Minh, should I select a different resolution and/or milestone?

The file doc/en/faq/Makefile was removed from revision control in Sage 4.5.alpha1:

[mvngu@sage sage-main]$ hg tags | grep '4.5.alpha'
4.5.alpha4                     14585:31da167254fd
4.5.alpha3                     14573:8bb71030944a
4.5.alpha2                     14567:1be02074cf97
4.5.alpha1                     14563:c25e907dc34d
4.5.alpha0                     14531:8dec8b43ccca
[mvngu@sage sage-main]$ hg export 14532 | head
# HG changeset patch
# User Robert Miller <rlm@rlmiller.org>
# Date 1277467893 25200
# Node ID c3719ae4c319132134fc1ff501e134d9930648d8
# Parent  8dec8b43ccca5f104b1e280cb33c8f4c2c1b8f85
Added tag 4.5.alpha0 for changeset 8dec8b43ccca

diff --git a/.hgtags b/.hgtags
--- a/.hgtags
+++ b/.hgtags
[mvngu@sage sage-main]$ hg export 14534 | head
# HG changeset patch
# User Robert Miller <rlm@rlmiller.org>
# Date 1277743380 25200
# Node ID ddd5427e99b9d7ba94842c479bf3bfd5b3e08ff9
# Parent  5c14ca9acdd371af75f7e9cc8fc342c8bbd2ed05
Remove doc/en/faq/Makefile from revision control

diff --git a/doc/en/faq/Makefile b/doc/en/faq/Makefile
deleted file mode 100644
--- a/doc/en/faq/Makefile
[mvngu@sage sage-main]$ hg export 14564 | head
# HG changeset patch
# User Robert Miller <rlm@rlmiller.org>
# Date 1277828988 25200
# Node ID 995b80b5b58b0374c04d891c35159cce5c48a0a6
# Parent  c25e907dc34d83f4ed0b0edf0fdfb06cc5eba957
Added tag 4.5.alpha1 for changeset c25e907dc34d

diff --git a/.hgtags b/.hgtags
--- a/.hgtags
+++ b/.hgtags

The ticket then should be resolved as fixed in milestone 4.5 and merged in 4.5.alpha1.

comment:7 in reply to: ↑ 4 Changed 9 years ago by mvngu

Replying to mpatel:

Just to check: Should we keep doc/en/tutorial/Makefile?

I think it can safely be deleted. We need to ensure that its removal has no effect on building the HTML and PDF versions of the documentation.

comment:8 Changed 9 years ago by mpatel

  • Merged in set to sage-4.5.alpha1
  • Milestone changed from sage-duplicate/invalid/wontfix to sage-4.5

comment:9 Changed 9 years ago by mpatel

  • Authors set to Robert Miller

Thanks, Minh! (Yes, I should have figured that out myself.) Do you mind being listed as the reviewer, possibly/albeit after the fact?

I've opened #9563 for removing doc/en/tutorial/Makefile.

comment:10 Changed 9 years ago by mvngu

  • Reviewers set to Minh Van Nguyen
Note: See TracTickets for help on using tickets.