Opened 10 years ago

Closed 10 years ago

#9313 closed defect (fixed)


Reported by: wuthrich Owned by: cremona
Priority: minor Milestone: sage-4.5.2
Component: elliptic curves Keywords:
Cc: wstein Merged in: sage-4.5.2.alpha0
Authors: David Loeffler Reviewers: Jamie Weigandt
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by wuthrich)

This file, implementing an interface for the p-adic height computation in MAGMA, is deprecated for a long time and no one is using it any more. This should be deleted now.

Attachments (1)

trac_9313-remove_padic_height.patch (4.6 KB) - added by davidloeffler 10 years ago.
patch against 4.4.4

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by davidloeffler

patch against 4.4.4

comment:1 Changed 10 years ago by davidloeffler

  • Status changed from new to needs_review

Here's a patch.

comment:2 Changed 10 years ago by weigandt

  • Status changed from needs_review to positive_review

Looks fine. Doctests check out.

comment:3 Changed 10 years ago by wuthrich

  • Authors set to David Loeffler
  • Description modified (diff)
  • Milestone set to sage-4.5
  • Reviewers set to Jamie Weigandt

Agree (though I have not run the tests). Moreover I can confirm that the author, William Stein, is happy that this is deleted.

Thanks, Jamie and David.

comment:4 Changed 10 years ago by mpatel

  • Merged in set to sage-4.5.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.