Opened 9 years ago

Last modified 5 years ago

#9311 new defect

Add an spkg-check file for ratpoints

Reported by: drkirkby Owned by: tbd
Priority: major Milestone: sage-6.4
Component: spkg-check Keywords:
Cc: leif, jhpalmieri, pjeremy Merged in:
Authors: Reviewers:
Report Upstream: Reported upstream. Developers acknowledge bug. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Ratpoints is one of the many standard packages in Sage (see #9281 for a list), which do not have a spkg-check file. This means that if one builds Sage with the environment variable SAGE_CHECK set to "yes", no self-tests of ratpoints will be run. This is silly, as there is a small test suite.

Dave

Change History (9)

comment:1 Changed 9 years ago by drkirkby

  • Milestone set to sage-4.5

comment:2 Changed 9 years ago by drkirkby

  • Report Upstream changed from N/A to Not yet reported upstream; Will do shortly.

This is not quite as simple as one would like on Solaris, as the test suite makes use of a non-POSIX '-u' option to diff

http://www.opengroup.org/onlinepubs/009695399/utilities/diff.html

so generates this as an output:

Successfully installed ratpoints-2.1.3.p2
Running the test suite.
Testing a 64-bit version of ratpoints
gcc rptest.c -o rptest -I/export/home/drkirkby/sage-4.4.4.alpha1/local/include -Wall -O2 -fPIC -DRATPOINTS_MAX_BITS_IN_PRIME= -DUSE_SSE -L/export/home/drkirkby/sage-4.4.4.alpha1/local/lib -lgmp -lm -L. -lratpoints -m64 
time ./rptest > rptest.out

real	0m0.05s
user	0m0.00s
sys	0m0.00s
diff -q testbase rptest.out
diff: illegal option -- q
usage: diff [-bitw] [-c | -e | -f | -h | -n | -u] file1 file2
       diff [-bitw] [-C number | -U number] file1 file2
       diff [-bitw] [-D string] file1 file2
       diff [-bitw] [-c | -e | -f | -h | -n | -u] [-l] [-r] [-s] [-S name] directory1 directory2
make: *** [test] Error 2
An error occurred while testing ratpoints

comment:3 Changed 9 years ago by drkirkby

Sorry, the illegal option is '-q', not '-u' as stated.

comment:4 Changed 9 years ago by drkirkby

  • Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. Little or no feedback.

I emailed this bug report to the developer. I think using 'cmp' rather than 'diff -q' would work fine. Will test it for sure.

Dave

comment:5 Changed 9 years ago by drkirkby

  • Cc leif jhpalmieri pjeremy added
  • Report Upstream changed from Reported upstream. Little or no feedback. to Reported upstream. Developers acknowledge bug.

comment:6 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:7 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:8 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:9 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.