Opened 11 years ago

Closed 6 weeks ago

#9301 closed defect (invalid)

Modified check_edge_label in the sparse graph backend to consider equals the same objects rather than objects with the same contents

Reported by: comick Owned by: jason, mvngu, ncohen, rlm
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: graph theory Keywords: graph, label
Cc: nathann.cohen@… Merged in:
Authors: Michele Comignano Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Modified check_edge_label in the sparse graph backend to consider equals the same objects rather than objects with the same contents. Discussion and example here: http://groups.google.com/group/sage-devel/browse_thread/thread/310fba4f1c119e63#

Attachments (3)

14371.patch (756 bytes) - added by comick 11 years ago.
Patch
doctest.py (721 bytes) - added by comick 11 years ago.
Doctest for bad behavior.
trac_9301-part1.patch (764 bytes) - added by rlm 11 years ago.
Replaces previous patch - added trac # to commit message.

Download all attachments as: .zip

Change History (13)

Changed 11 years ago by comick

Patch

comment:1 Changed 11 years ago by comick

  • Status changed from new to needs_review

comment:2 Changed 11 years ago by rlm

  • Status changed from needs_review to needs_work

Since this is a bug fix, you need to include a doctest which illustrates the bug you are fixing.

Changed 11 years ago by comick

Doctest for bad behavior.

comment:3 Changed 11 years ago by comick

  • Status changed from needs_work to needs_review

Changed 11 years ago by rlm

Replaces previous patch - added trac # to commit message.

comment:4 Changed 11 years ago by rlm

  • Report Upstream changed from Workaround found; Bug reported upstream. to N/A
  • Status changed from needs_review to needs_work

There is a fly in the ointment:

During one of the last NetworkX upgrades, many common Sage graph constructors were modified to give empty dictionaries as labels instead of None. I have been intending to fix many of Sage's graph generators not to depend on NetworkX (since simply constructing a CGraph would be much quicker), and revert the edge situation back to having labels equal to None. But until that happens, this patch causes several failures:

sage -t -long "devel/sage-main/sage/graphs/generic_graph.py"
sage -t -long "devel/sage-main/sage/graphs/base/sparse_graph.pyx"
sage -t -long "devel/sage-main/sage/graphs/graph.py"

Also, I've changed the "Report Upstream" since here we *are* the upstream.

comment:5 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:6 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:7 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:8 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:9 Changed 7 weeks ago by dcoudert

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Reviewers set to David Coudert
  • Status changed from needs_work to positive_review

It seems that this issue has been fixed long time ago. So I propose to close this ticket.

comment:10 Changed 6 weeks ago by mkoeppe

  • Resolution set to invalid
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.