Opened 9 years ago

Closed 9 years ago

#9287 closed defect (fixed)

improving doctest coverage for elliptic curves

Reported by: wuthrich Owned by: cremona
Priority: minor Milestone: sage-4.5.2
Component: elliptic curves Keywords: doctest coverage
Cc: wstein Merged in: sage-4.5.2.alpha0
Authors: Chris Wuthrich Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by wuthrich)

The bad files (at 4.4.4.alpha0) are

  • BSD.py 85% (6 of 7)
  • ell_egros.py 85% (6 of 7)
  • ell_modular_symbols.py 86% (13 of 15)
  • gp_cremona.py 85% (6 of 7)
  • gp_simon.py 50% (1 of 2)
  • mod5family.py 0% (0 of 1)
  • monsky_washnitzer.py 26% (28 of 107)
  • padic_height.py 0% (0 of 6) #deprecated
  • padic_lseries.py 59% (19 of 32)
  • padics.py 83% (10 of 12)
  • sea.py 0% (0 of 1)
  • sha_tate.py 80% (8 of 10)

Attachments (2)

trac_9287.coverage_for_elliptic_curves_part1.patch (15.3 KB) - added by wuthrich 9 years ago.
exported against 4.4.4.alpha0
trac_9287.coverage_for_elliptic_curves_part2.patch (11.4 KB) - added by wuthrich 9 years ago.
also exported against 4.4.4.alpha0

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by wuthrich

  • Description modified (diff)

So far I have dealt with

  • padic_lseries.py
  • modular_parametrization.py
  • padics.py

... more to come

comment:2 Changed 9 years ago by wuthrich

  • Description modified (diff)

Changed 9 years ago by wuthrich

exported against 4.4.4.alpha0

Changed 9 years ago by wuthrich

also exported against 4.4.4.alpha0

comment:3 Changed 9 years ago by wuthrich

  • Cc wstein added
  • Status changed from new to needs_review

The second patch (indep of the first) takes care of

  • ell_modular_symbol
  • sha_tate
  • ell_torsion

See trac ticket #9313 of how to take care of padic_height.py

That is how far I will do improve the documentation so far. If someone else would like to improve it further either put it back to needs_work and continue the work here or (prefered by me) open a new ticket.

comment:4 Changed 9 years ago by cremona

  • Reviewers set to John Cremona
  • Status changed from needs_review to positive_review

Patches apply fine to 4.4.4.alpha0, and test pass, and docs build and look fine!

comment:5 Changed 9 years ago by cremona

  • Milestone changed from sage-5.0 to sage-4.5.1

comment:6 Changed 9 years ago by mpatel

  • Merged in set to sage-4.5.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.