Opened 12 years ago

Closed 12 years ago

#9286 closed defect (fixed)

Add an spkg-check file for boehm_gc

Reported by: David Kirkby Owned by: tbd
Priority: minor Milestone: sage-4.5
Component: spkg-check Keywords:
Cc: Merged in: sage-4.5.alpha0
Authors: David Kirkby Reviewers: Ivan Andrus
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by David Kirkby)

boehm_gc is one of the many standard packages in Sage (see #9281 for a list), which do not have a spkg-check file. This means that if one builds Sage with the environment variable SAGE_CHECK set to "yes", no self-tests of the package will be run. This is silly, as boehm_gc has a test suite.

After adding the required file, the test suite is run. This has been checked on OpenSolaris x64 in 64-bit mode and Solaris 10 SPARC in 32-bit mode.

creating threadleaktest
make[2]: Leaving directory `/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/boehm_gc-7.1.p6/src'
make  check-TESTS
make[2]: Entering directory `/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/boehm_gc-7.1.p6/src'
Completed 3 tests
Allocated 4030601 collectable objects
Allocated 306 uncollectable objects
Allocated 2527886 atomic objects
Allocated 34362 stubborn objects
Finalized 6761/6761 objects - finalization is probably ok
Total number of bytes allocated is 227907342
Final heap size is 19632128 bytes
Collector appears to work
Completed 106 collections
PASS: gctest
Leaked composite object at 4daec0 (tests/leak_test.c:19, sz=8, NORMAL)

PASS: leaktest
Final heap size is 524288
PASS: middletest
GC_check_heap_block: found smashed heap objects:
4e8fe8 in or near object at 4e8fc0(tests/smash_test.c:21, sz=40)
GC_check_heap_block: found smashed heap objects:
55bae8 in or near object at 55bac0(tests/smash_test.c:21, sz=40)
4e8fe8 in or near object at 4e8fc0(tests/smash_test.c:21, sz=40)
PASS: smashtest
GC Warning: Out of Memory!  Returning NIL!
GC Warning: Out of Memory!  Returning NIL!
GC Warning: Out of Memory!  Returning NIL!
PASS: hugetest
Leaked composite object at 4daf80 (tests/thread_leak_test.c:14, sz=4, NORMAL)

Leaked composite object at start: 4daf90, appr. length: 48
Leaked composite object at 4dae00 (tests/thread_leak_test.c:14, sz=4, NORMAL)

Leaked composite object at 4daef0 (tests/thread_leak_test.c:14, sz=4, NORMAL)

Leaked composite object at start: 4dae10, appr. length: 48
Leaked composite object at 4dadd0 (tests/thread_leak_test.c:14, sz=4, NORMAL)

Leaked composite object at 4dae90 (tests/thread_leak_test.c:14, sz=4, NORMAL)

PASS: threadleaktest
==================
All 6 tests passed
==================
make[2]: Leaving directory `/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/boehm_gc-7.1.p6/src'
make[1]: Leaving directory `/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/boehm_gc-7.1.p6/src'
Now cleaning up tmp files.
rm: Cannot remove any directory in the path of the current working directory
/export/home/drkirkby/sage-4.4.4.alpha1/spkg/build/boehm_gc-7.1.p6
Making Sage/Python scripts relocatable...
Making script relocatable
Finished installing boehm_gc-7.1.p6.spkg

Attachments (1)

9286.patch (1.1 KB) - added by David Kirkby 12 years ago.
Mercurial patch to add an spkg-check to enable self-tests

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by David Kirkby

Attachment: 9286.patch added

Mercurial patch to add an spkg-check to enable self-tests

comment:1 Changed 12 years ago by David Kirkby

Description: modified (diff)

comment:2 Changed 12 years ago by David Kirkby

Here's the package, which will perform some self-tsts if SAGE_CHECK is exported to "yes"

http://boxen.math.washington.edu/home/kirkby/patches/boehm_gc-7.1.p6.spkg

comment:3 Changed 12 years ago by Ivan Andrus

Resolution: fixed
Reviewers: Ivan Andrus
Status: newclosed

I read the patch and I approve. I ran

sage -i http://boxen.math.washington.edu/home/kirkby/patches/boehm_gc-7.1.p6.spkg

which did not run any tests, and then

SAGE_CHECK=yes sage -f -i http://boxen.math.washington.edu/home/kirkby/patches/boehm_gc-7.1.p6.spkg

which did. All tests passed on

uname -a
Darwin parduc.home 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386 i386

Congratulations, you are now the proud owner of a brand new Positive Review!

comment:4 Changed 12 years ago by Ivan Andrus

Resolution: fixed
Status: closednew

comment:5 Changed 12 years ago by Ivan Andrus

Status: newneeds_review

comment:6 Changed 12 years ago by Ivan Andrus

Status: needs_reviewpositive_review

Oops, I closed it instead of giving positive review.

comment:7 Changed 12 years ago by Robert Miller

Merged in: sage-4.5.alpha0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.