Opened 7 years ago

Last modified 12 months ago

#9280 needs_work enhancement

Implement an example of a graded algebra with basis, and improve the later

Reported by: jhpalmieri Owned by: nthiery
Priority: minor Milestone: sage-7.4
Component: categories Keywords: graded algebra
Cc: Merged in:
Authors: John Palmieri, Nicolas M. Thiéry Reviewers: Frédéric Chapoton, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: public/categories/graded_examples-9280 (Commits) Commit: fb05e6c33b3202e0b0defb75007abd5bc7a6c5fd
Dependencies: #10193 #12453 Stopgaps:

Description (last modified by jhpalmieri)

The summary says it all. See also the patch on the Sage-Combinat patch server:

http://combinat.sagemath.org/hgwebdir.cgi/patches/file/tip/trac_9280-graded-algebras-example.patch

Thanks to Jason Bandlow and Franco Saliola who participated to the improvement of the example. It now depends on #10193.

Attachments (4)

trac_9280-graded-algebras-example.patch (19.8 KB) - added by jhpalmieri 7 years ago.
trac_9280-ref.patch (4.0 KB) - added by jhpalmieri 7 years ago.
apply on top of sage-combinat patch
trac_9280-graded-algebras-example-fs.patch (44.0 KB) - added by chapoton 4 years ago.
trac_9280_nomodule.patch (19.2 KB) - added by chapoton 4 years ago.

Download all attachments as: .zip

Change History (28)

comment:1 Changed 7 years ago by jhpalmieri

  • Status changed from new to needs_review

Changed 7 years ago by jhpalmieri

comment:2 follow-up: Changed 7 years ago by nthiery

Hi John,

For the record: we went through your patches with Franco and Jason, and discussed quite a bit around it. We will post here shortly an updated patch with some little suggestions.

comment:3 in reply to: ↑ 2 Changed 7 years ago by jhpalmieri

Replying to nthiery:

Hi John,

For the record: we went through your patches with Franco and Jason, and discussed quite a bit around it. We will post here shortly an updated patch with some little suggestions.

Is it "shortly" yet? :)

comment:4 Changed 7 years ago by nthiery

  • Authors changed from John Palmieri to John Palmieri, Nicolas M. Thiéry
  • Description modified (diff)
  • Summary changed from implement an example of a graded algebra with basis to Implement an example of a graded algebra with basis, and improve the later

comment:5 Changed 7 years ago by jhpalmieri

  • Description modified (diff)

comment:6 Changed 7 years ago by jhpalmieri

In the sage-combinat patch, there are a few typos and some other issues:

  • in sage/categories/graded_algebras_with_basis.py, the docstring for "degree" says "The degree of this element in the graded polynomial algebra." Delete "polynomial".
  • in sage/categories/examples/graded_algebras_with_basis.py, the docstring for "one_basis" contains '(0,...,0`), and I think this should be changed to ``(0,...,0)``.
  • in sage/categories/examples/graded_algebras_with_basis.py, the docstring for the main class is now outdated: it still refers to "basis_function" and "_basis_fcn", which don't exist any more, and also to "homogeneous_component", which is now part of the default implementation, not something specific to this example.

I'm attaching a referee patch which fixes these.

There are also some doctests for "basis" in sage/categories/graded_algebras_with_basis.py which are marked as "todo: not implemented". Do we need to wait for these to be fixed, or should we consider this ready for review? It may not be ideal, but we could also change

sage: A.basis(6) # todo: not implemented (output)
Family (y^{2}, x^{3}

to

sage: A.basis(6) # todo: not implemented (output)
Family (y^{2}, x^{3}
sage: list(A.basis(6))
[y^{2}, x^{3}]

By the way, all tests pass with this patch and with the one from #10193. So perhaps we could also delete the commented-out part at the beginning of the example, where it says

# TODO: double check that we can now discard this function

Changed 7 years ago by jhpalmieri

apply on top of sage-combinat patch

comment:7 Changed 6 years ago by chapoton

  • Dependencies set to #10193

comment:8 Changed 5 years ago by saliola

There are a couple of patches on the sage-combinat queue experimenting with moving some of the generic methods into the category GradedAlgebraWithBasis:

  • trac_9280-graded-algebras-example-review-fs.patch
  • trac_9280-graded-algebras-example.patch

comment:9 Changed 5 years ago by vdelecroix

Sorry for the long delay for the ticket but #10193 is now ready !!

comment:10 Changed 4 years ago by chapoton

  • Keywords graded algebra added

comment:11 Changed 4 years ago by chapoton

Franco, Nicolas, what can we do with this ticket ? Should we use the patch from the combinat queue or the patch here ?

Changed 4 years ago by chapoton

comment:12 Changed 4 years ago by chapoton

let me take the patch of sage-combinat as a starting point.

for the bot: apply only trac_9280-graded-algebras-example-fs.patch

comment:13 Changed 4 years ago by jhpalmieri

I don't know why I'm listed as an author in the file "sage/categories/examples/graded_modules_with_basis.py"; I don't think I had anything to do with that.

comment:14 Changed 4 years ago by chapoton

The part of this patch concerning modules has been separated into ticket #11688 : the ticket #11688 should go first, then this one will need to be rebased on it.

I upload here the "algebra only patch" that will be the new starting point.

Changed 4 years ago by chapoton

comment:15 Changed 4 years ago by chapoton

  • Status changed from needs_review to needs_work

this needs to be rebased

comment:16 Changed 4 years ago by tscrim

  • Dependencies changed from #10193 to #10193 #12453
  • Status changed from needs_work to needs_review

Since the graded algebras with basis example is using (weighted) integer vectors, we need #12453. I'd like to attach the branch "public/categories/graded_examples-9280", but trac is giving me an error when I try...

comment:17 Changed 4 years ago by tscrim

  • Branch set to public/categories/graded_examples-9280
  • Commit set to 32dc8072c40a03e67e4dffb3075cb990b988ccb1
  • Reviewers set to Frederic Chapoton, Travis Scrimshaw

New commits:

32dc807Fixed failing doctests.
c467bdbMerge branch 'public/refactor_integer_vectors-12453' into public/categories/graded_examples-9280
ef2ddce#12453: Refactored IntegerVectors to use ClonableIntArray.
c82765fInitial review changes.
e2c3ae8Merge branch 'public/categories/examples-9280' into public/categoires/graded_example-9280
6fffda7Merge branch 'master' into public/categories/examples-9280
3491e78imported patch trac_9280_nomodule.patch

comment:18 Changed 4 years ago by chapoton

  • Reviewers changed from Frederic Chapoton, Travis Scrimshaw to Frédéric Chapoton, Travis Scrimshaw

comment:19 Changed 4 years ago by git

  • Commit changed from 32dc8072c40a03e67e4dffb3075cb990b988ccb1 to 2346b02544295e7df084dd65b4f509e59cfe9584

Branch pushed to git repo; I updated commit sha1. New commits:

161cedbMerge branch 'develop' into public/categories/graded_examples-9280
badae2aMerge branch 'develop' into public/categories/graded_examples-9280
eb793ccMerge branch 'develop' into public/refactor_integer_vectors-12453
b9f278eMerge branch 'develop' into public/refactor_integer_vectors-12453
2346b02Merge branch 'public/refactor_integer_vectors-12453' into public/categories/graded_examples-9280

comment:20 Changed 4 years ago by git

  • Commit changed from 2346b02544295e7df084dd65b4f509e59cfe9584 to fb05e6c33b3202e0b0defb75007abd5bc7a6c5fd

Branch pushed to git repo; I updated commit sha1. New commits:

12bac19Merge branch 'develop' into public/refactor_integer_vectors-12453
fb05e6cMerge branch 'public/refactor_integer_vectors-12453' into public/categories/graded_examples-9280

comment:21 Changed 3 years ago by chapoton

  • Status changed from needs_review to needs_work

needs rebase

comment:22 Changed 2 years ago by chapoton

  • Milestone set to sage-6.8

comment:23 Changed 12 months ago by jhpalmieri

Yet another instance of someone asking a question related to this. Six (!) years ago, when I opened this ticket, I thought it would be good to have an example in the Sage library and in the documentation, and I really can't understand why this hasn't been taken care of yet. I am not interested in working on it myself any more, but I find it incredibly frustrating that this ticket has languished for so long.

http://ask.sagemath.org/question/34577/can-sage-compute-a-basis-for-the-graded-parts-of-a-graded-ring/

comment:24 Changed 12 months ago by tscrim

  • Milestone changed from sage-6.8 to sage-7.4

It is because of the dependency on integer vectors, which led to #12453. We can either give a new example based on another object or we review #12453 (which I just did a [non-trivial] rebase to the latest beta).

Note: See TracTickets for help on using tickets.