Opened 13 years ago

Closed 13 years ago

#9272 closed defect (fixed)

make -only-optional=... case-insensitive

Reported by: jhpalmieri Owned by: mvngu
Priority: minor Milestone: sage-4.5
Component: doctest coverage Keywords:
Cc: Merged in: sage-4.5.alpha0
Authors: John Palmieri Reviewers: Robert Miller
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Some doctests in sage/homology/tests.py are marked # optional - CHomP (or they should be marked this way: see #9270 and #9271). Running sage -t -only-optional=chomp tests.py runs those tests, but running sage -t -only-optional=CHomP tests.py does not.

Attachments (1)

trac_9272-only-optional-case-insensitive.patch​ (809 bytes) - added by jhpalmieri 13 years ago.
scripts repo

Download all attachments as: .zip

Change History (4)

comment:1 Changed 13 years ago by jhpalmieri

Status: new → needs_review

Here's a patch for the scripts repo. During parsing, the line being doctested gets converted to lower-case (line 245 in sage-doctest), but the arguments for "-only-optional" were not being converted. The patch fixes this.

Changed 13 years ago by jhpalmieri

Attachment: trac_9272-only-optional-case-insensitive.patch​ added

scripts repo

comment:2 Changed 13 years ago by rlm

Authors: → John Palmieri
Reviewers: → Robert Miller
Status: needs_review → positive_review

Looks good to me!

comment:3 Changed 13 years ago by rlm

Merged in: → sage-4.5.alpha0
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.