Opened 13 years ago
Closed 13 years ago
#9272 closed defect (fixed)
make -only-optional=... case-insensitive
Reported by: | jhpalmieri | Owned by: | mvngu |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.5 |
Component: | doctest coverage | Keywords: | |
Cc: | Merged in: | sage-4.5.alpha0 | |
Authors: | John Palmieri | Reviewers: | Robert Miller |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Attachments (1)
Change History (4)
comment:1 Changed 13 years ago by
Status: | new → needs_review |
---|
Changed 13 years ago by
Attachment: | trac_9272-only-optional-case-insensitive.patch added |
---|
scripts repo
comment:2 Changed 13 years ago by
Authors: | → John Palmieri |
---|---|
Reviewers: | → Robert Miller |
Status: | needs_review → positive_review |
Looks good to me!
comment:3 Changed 13 years ago by
Merged in: | → sage-4.5.alpha0 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Here's a patch for the scripts repo. During parsing, the line being doctested gets converted to lower-case (line 245 in sage-doctest), but the arguments for "-only-optional" were not being converted. The patch fixes this.