Opened 11 years ago

Closed 11 years ago

#9258 closed defect (fixed)

problem with converting FriCAS domains to Sage objects

Reported by: awebb Owned by: tbd
Priority: minor Milestone: sage-4.5.2
Component: packages: optional Keywords:
Cc: Merged in: sage-4.5.2.alpha0
Authors: Mike Hansen Reviewers: Adam Webb
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by awebb)

Fricas seems to have an api change which breaks a few tests in fricas.py. 

def _sage_domain(self):
        """
        A helper function for converting FriCAS domains to the corresponding
        Sage object.
        
        EXAMPLES::
        
            sage: fricas('Integer').sage() #optional - fricas
            Integer Ring
            sage: fricas('Fraction Integer').sage() #optional - fricas
            Rational Field
            sage: fricas('DoubleFloat').sage() #optional - fricas
            Real Double Field

        """

These now give either a different return value or simply results in raising a NotImplementedError?.

Attachments (1)

trac_9258.patch​ (621 bytes) - added by mhansen 11 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by awebb

  • Description modified (diff)

Changed 11 years ago by mhansen

comment:2 Changed 11 years ago by mhansen

  • Authors set to Mike Hansen
  • Status changed from new to needs_review

comment:3 Changed 11 years ago by awebb

  • Reviewers set to Adam Webb
  • Status changed from needs_review to positive_review

That was easier than I thought it would be. :-)

Adam

comment:4 Changed 11 years ago by mpatel

  • Merged in set to sage-4.5.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.