Opened 11 years ago

Closed 11 years ago

#9239 closed defect (fixed)

delete the (ridiculous) method __copy__ from matrix0.pyx

Reported by: was Owned by: jason, was
Priority: minor Milestone: sage-4.5.2
Component: linear algebra Keywords:
Cc: Merged in: sage-4.5.2.alpha0
Authors: Florent Hivert Reviewers: William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mvngu)

__copy__ was overloaded, never used.

See this ​sage-devel thread for background information.

Attachments (1)

trac_9239-matrix_copy_remove-fh.patch​ (1.7 KB) - added by hivert 11 years ago.

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by hivert

comment:1 Changed 11 years ago by hivert

  • Authors set to Florent Hivert
  • Description modified (diff)
  • Status changed from new to needs_review

Note: the doctest where duplicated from the .copy() method so I didn't kept them.

Please review

comment:2 Changed 11 years ago by was

  • Status changed from needs_review to positive_review

Yep.

comment:3 Changed 11 years ago by mvngu

  • Description modified (diff)

comment:4 Changed 11 years ago by davidloeffler

  • Reviewers set to William Stein

comment:5 Changed 11 years ago by mpatel

  • Merged in set to sage-4.5.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.