Changes between Version 26 and Version 30 of Ticket #9232


Ignore:
Timestamp:
Mar 29, 2011, 1:34:50 PM (12 years ago)
Author:
kcrisman
Comment:

Jonathan, definitely keep working on #9238. Jason can just put those things in the new notebook. Having something working completely is a very good idea, and we can continue to test it on the old notebook, which is still the current notebook, after all.

I do think we need to also add the piece of #9238 that changes the lighting. Currently I have good lighting in the command line and bad lighting in the notebook, even without the new jmol - someone the new jmol is called from the notebook, even though I didn't install it in this version!!! I even checked this in the advanced menu. Mystifying.

I'm just testing quick, and then I'll post patches. Since they aren't mine, I feel free to give positive review.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9232

    • Property Status changed from needs_review to positive_review
  • Ticket #9232 – Description

    v26 v30  
    4747----
    4848
    49 Install [http://www.uwosh.edu/faculty_staff/gutow/Jmol_for_SageNoteBook-1.1.5.spkg this spkg] and apply [attachment:trac_9232_plot3d_base_pyx.patch] and [attachment:trac_9232_call_jmol_correctly.patch].
     49Apply ''only'' [attachment:trac_9232_call_jmol_correctly.patch].