Opened 11 years ago

Closed 10 years ago

#9227 closed enhancement (fixed)

units.length.millimeter missing

Reported by: schilly Owned by: AlexGhitza
Priority: trivial Milestone: sage-4.6.2
Component: misc Keywords:
Cc: asjarman@… Merged in: sage-4.6.2.alpha2
Authors: Martin Allen Reviewers: Simon Spicer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

a millimeter [mm] is 1/1000 of a meter and very often used by engineers.

Attachments (2)

trac_9227_mm_and_km_units.patch (2.7 KB) - added by allmar 11 years ago.
patch to add mm and km
trac_9227_mm_and_km_units.2.patch (2.2 KB) - added by spice 10 years ago.

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by allmar

patch to add mm and km

comment:1 Changed 11 years ago by allmar

  • Status changed from new to needs_review

comment:2 Changed 11 years ago by AlexGhitza

  • Component changed from algebra to misc

comment:3 Changed 10 years ago by aapitzsch

You mentioned

Equal to 1000 meters.

twice. You should replace one by a comparison to yards, feet or something else.

Changed 10 years ago by spice

comment:4 Changed 10 years ago by spice

  • Authors set to Martin Allen
  • Reviewers set to Simon Spicer

Doctests fail due to there being TAB characters in this patch.

I've added an updated patch, which replaces the TAB characters in the patch with spaces, as well as changing line 650: 'kilometer':'Equal to 1000 meters.\nEqual to 1000 meters.', to 'kilometer':'Equal to 1000 meters.\nEqual to 3280.8399 feet.',

comment:5 Changed 10 years ago by aly.deines

  • Status changed from needs_review to positive_review

Looks good to me.

comment:6 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-4.6.1 to sage-4.6.2

comment:7 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.