Opened 10 years ago

Closed 10 years ago

Last modified 5 years ago

#9222 closed enhancement (fixed)

improve doctest coverage of databases/conway.py

Reported by: AlexGhitza Owned by: tbd
Priority: minor Milestone: sage-4.5.2
Component: doctest coverage Keywords: conway polynomial database
Cc: mvngu Merged in: sage-4.5.2.alpha1
Authors: Alex Ghitza Reviewers: David Loeffler
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by chapoton)

As of sage-4.4.3: 

----------------------------------------------------------------------
conway.py
ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE conway.py: 0% (0 of 7)

Missing documentation:
 * _init(self):
 * __repr__(self):
 * polynomial(self, p, n):
 * has_polynomial(self, p, n):
 * primes(self):
 * degrees(self, p):

Missing doctests:
 * __init__(self, read_only=True):

----------------------------------------------------------------------

Attachments (1)

trac_9222.patch​ (4.5 KB) - added by AlexGhitza 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by mvngu

  • Cc mvngu added

comment:2 Changed 10 years ago by AlexGhitza

  • Authors set to Alex Ghitza
  • Status changed from new to needs_review

After the patch: 

ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE conway.py: 85% (6 of 7)

Missing documentation:
	 * _init(self):

I'm not convinced a TestSuite test makes sense here (and I have tried to put one in and got a pickling-related error). Also, I'm not sure what _init(self) is meant to be doing, so I'm leaving it alone for now.

comment:3 Changed 10 years ago by davidloeffler

  • Status changed from needs_review to positive_review

Looks fine to me. Tests pass and the documentation builds OK. I agree that the _init method isn't something one can reasonably doctest!

comment:4 Changed 10 years ago by davidloeffler

  • Reviewers set to David Loeffler

comment:5 Changed 10 years ago by ddrake

  • Status changed from positive_review to needs_work

Please include ticket numbers in the commit strings of your patches!

Changed 10 years ago by AlexGhitza

comment:6 follow-up: Changed 10 years ago by AlexGhitza

  • Status changed from needs_work to positive_review

Done.

comment:7 in reply to: ↑ 6 Changed 10 years ago by ddrake

  • Merged in set to sage-4.5.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed

Replying to AlexGhitza:

Done.

Thanks!

comment:8 Changed 5 years ago by chapoton

  • Description modified (diff)
Note: See TracTickets for help on using tickets.