Opened 12 years ago

Closed 12 years ago

Last modified 7 years ago

#9222 closed enhancement (fixed)

improve doctest coverage of databases/conway.py

Reported by: Alex Ghitza Owned by: tbd
Priority: minor Milestone: sage-4.5.2
Component: doctest coverage Keywords: conway polynomial database
Cc: Minh Van Nguyen Merged in: sage-4.5.2.alpha1
Authors: Alex Ghitza Reviewers: David Loeffler
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Frédéric Chapoton)

As of sage-4.4.3: 

----------------------------------------------------------------------
conway.py
ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE conway.py: 0% (0 of 7)

Missing documentation:
 * _init(self):
 * __repr__(self):
 * polynomial(self, p, n):
 * has_polynomial(self, p, n):
 * primes(self):
 * degrees(self, p):

Missing doctests:
 * __init__(self, read_only=True):

----------------------------------------------------------------------

Attachments (1)

trac_9222.patch​ (4.5 KB) - added by Alex Ghitza 12 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 12 years ago by Minh Van Nguyen

Cc: Minh Van Nguyen added

comment:2 Changed 12 years ago by Alex Ghitza

Authors: → Alex Ghitza
Status: new → needs_review

After the patch: 

ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE conway.py: 85% (6 of 7)

Missing documentation:
	 * _init(self):

I'm not convinced a TestSuite test makes sense here (and I have tried to put one in and got a pickling-related error). Also, I'm not sure what _init(self) is meant to be doing, so I'm leaving it alone for now.

comment:3 Changed 12 years ago by David Loeffler

Status: needs_review → positive_review

Looks fine to me. Tests pass and the documentation builds OK. I agree that the _init method isn't something one can reasonably doctest!

comment:4 Changed 12 years ago by David Loeffler

Reviewers: → David Loeffler

comment:5 Changed 12 years ago by Dan Drake

Status: positive_review → needs_work

Please include ticket numbers in the commit strings of your patches!

Changed 12 years ago by Alex Ghitza

Attachment: trac_9222.patch​ added

comment:6 Changed 12 years ago by Alex Ghitza

Status: needs_work → positive_review

Done.

comment:7 in reply to:  6 Changed 12 years ago by Dan Drake

Merged in: → sage-4.5.2.alpha1
Resolution: → fixed
Status: positive_review → closed

Replying to AlexGhitza:

Done.

Thanks!

comment:8 Changed 7 years ago by Frédéric Chapoton

Description: modified (diff)
Note: See TracTickets for help on using tickets.