#9222 closed enhancement (fixed)
improve doctest coverage of databases/conway.py
Reported by: | AlexGhitza | Owned by: | tbd |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.5.2 |
Component: | doctest coverage | Keywords: | conway polynomial database |
Cc: | mvngu | Merged in: | sage-4.5.2.alpha1 |
Authors: | Alex Ghitza | Reviewers: | David Loeffler |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
As of sage-4.4.3:
---------------------------------------------------------------------- conway.py ERROR: Please add a `TestSuite(s).run()` doctest. SCORE conway.py: 0% (0 of 7) Missing documentation: * _init(self): * __repr__(self): * polynomial(self, p, n): * has_polynomial(self, p, n): * primes(self): * degrees(self, p): Missing doctests: * __init__(self, read_only=True): ----------------------------------------------------------------------
Attachments (1)
Change History (9)
comment:1 Changed 13 years ago by
Cc: | mvngu added |
---|
comment:2 Changed 13 years ago by
Authors: | → Alex Ghitza |
---|---|
Status: | new → needs_review |
comment:3 Changed 13 years ago by
Status: | needs_review → positive_review |
---|
Looks fine to me. Tests pass and the documentation builds OK. I agree that the _init method isn't something one can reasonably doctest!
comment:4 Changed 13 years ago by
Reviewers: | → David Loeffler |
---|
comment:5 Changed 13 years ago by
Status: | positive_review → needs_work |
---|
Please include ticket numbers in the commit strings of your patches!
Changed 13 years ago by
Attachment: | trac_9222.patch added |
---|
comment:7 Changed 13 years ago by
Merged in: | → sage-4.5.2.alpha1 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:8 Changed 7 years ago by
Description: | modified (diff) |
---|
Note: See
TracTickets for help on using
tickets.
After the patch:
I'm not convinced a
TestSuite
test makes sense here (and I have tried to put one in and got a pickling-related error). Also, I'm not sure what_init(self)
is meant to be doing, so I'm leaving it alone for now.