Opened 10 years ago

Closed 7 years ago

Last modified 4 years ago

#9165 closed defect (worksforme)

cygwin: lcalc does not work for elliptic curves on cygwin

Reported by: was Owned by: tbd
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: porting: Cygwin Keywords:
Cc: Merged in:
Authors: Reviewers: Karl-Dieter Crisman, Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by chapoton)

lcalc works fine for the zeta function on cygwin, evidently:

sage: time lcalc.zeros(4)
CPU times: user 0.00 s, sys: 0.00 s, total: 0.00 s
Wall time: 0.19 s
[14.1347251, 21.0220396, 25.0108576, 30.4248761]

However, it doesn't work for computing with elliptic curves:

sage -t  "devel/sage/sage/lfunctions/lcalc.py"              
  ***   not enough memory
  ***   not enough memory
  ***   not enough memory
**********************************************************************
File "/home/wstein/sage-4.4.3/devel/sage/sage/lfunctions/lcalc.py", line 120:
    sage: lcalc.zeros(3, EllipticCurve('37a'))     # long
Expected:
    [0.000000000, 5.00317001, 6.87039122]
Got:
    []
**********************************************************************
File "/home/wstein/sage-4.4.3/devel/sage/sage/lfunctions/lcalc.py", line 229:
    sage: E.lseries().values_along_line(0.5, 3, 5)
Expected:
    [(0, 0.209951303),
     (0.500000000, -...e-16),
     (1.00000000, 0.133768433),
     (1.50000000, 0.360092864),
     (2.00000000, 0.552975867)]
Got:
    lcalc:  
    []
**********************************************************************
File "/home/wstein/sage-4.4.3/devel/sage/sage/lfunctions/lcalc.py", line 374:
    sage: lcalc.analytic_rank(E)
Exception raised:
    Traceback (most recent call last):
      File "/home/wstein/sage-4.4.3/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/home/wstein/sage-4.4.3/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/home/wstein/sage-4.4.3/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_8[3]>", line 1, in <module>
        lcalc.analytic_rank(E)###line 374:
    sage: lcalc.analytic_rank(E)
      File "/home/wstein/sage-4.4.3/local/lib/python/site-packages/sage/lfunctions/lcalc.py", line 381, in analytic_rank
        return Z(s[i+6:])
      File "integer.pyx", line 614, in sage.rings.integer.Integer.__init__ (sage/rings/integer.c:6388)
    TypeError: unable to convert x (=) to an integer
**********************************************************************
3 items had failures:
   1 of   5 in __main__.example_2
   1 of   6 in __main__.example_5
   1 of   4 in __main__.example_8
***Test Failed*** 3 failures.
For whitespace errors, see the file /home/wstein/.sage//tmp/.doctest_lcalc.py
 [17.7 s]

Change History (10)

comment:1 Changed 10 years ago by was

Another test failure resulting from lcalc not working:

sage -t  "devel/sage/sage/plot/line.py"                     
  ***   not enough memory
**********************************************************************
File "/home/wstein/sage-4.4.3/devel/sage/sage/plot/line.py", line 375:
    sage: vals = E.lseries().values_along_line(1-I, 1+10*I, 100) # critical line
Expected nothing
Got:
    lcalc:  
**********************************************************************
1 items had failures:

comment:2 Changed 9 years ago by drkirkby

Note gcc gives many compiler warnings and SunStudio refuses to compile the source code. These matters are probably not entirely unrelated.

comment:3 Changed 8 years ago by kcrisman

The lfunctions/ directory appears to pass doctests on a recent build of mine on XP.

comment:4 Changed 8 years ago by kcrisman

plot/line.py also passes tests (though many others do not in plot/, perhaps due to "I" currently not working).

comment:5 Changed 8 years ago by kcrisman

But there is a segfault on the very first example above. Strange that the tests pass.

comment:6 Changed 7 years ago by kcrisman

  • Milestone changed from sage-5.6 to sage-duplicate/invalid/wontfix
  • Priority changed from major to minor
  • Reviewers set to Karl-Dieter Crisman
  • Status changed from new to needs_review

These both pass and work "by hand" on XP now. I do get warnings about the new stack size, which keeps going down from 1 MB to .981, .957, .955 with these commands, but they do work (as does the one in line.py) so I would suggest a different ticket for handling the stack on Cygwin.

JP, can you confirm these pass on Win 7? Then we should be set.

comment:7 Changed 7 years ago by jpflori

  • Status changed from needs_review to positive_review

For info, this file passes its tests on my Windows 7 install (without #13351).

So let's close this one.

comment:8 Changed 7 years ago by kcrisman

  • Reviewers changed from Karl-Dieter Crisman to Karl-Dieter Crisman, Jean-Pierre Flori

comment:9 Changed 7 years ago by jdemeyer

  • Resolution set to worksforme
  • Status changed from positive_review to closed

comment:10 Changed 4 years ago by chapoton

  • Description modified (diff)
Note: See TracTickets for help on using tickets.