Opened 12 years ago

Closed 11 years ago

#9122 closed enhancement (fixed)

conversions between simplicial and cubical complexes

Reported by: John Palmieri Owned by: John Palmieri
Priority: minor Milestone: sage-4.7.1
Component: algebraic topology Keywords:
Cc: mhampton Merged in: sage-4.7.1.alpha2
Authors: John Palmieri Reviewers: Marshall Hampton
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This patch implements conversions between simplicial and cubical complexes. It also implements the following: if you call

sage: SimplicialComplex(X)

it tests to see if X has a _simplicial_ method, and if it does, it calls that and returns the answer. So if anyone wants to convert their favorite Sage object to a simplicial complex, they just have to write a _simplicial_ method for it; then SimplicialComplex(blah) will work. Same for a _cubical_ method and cubical complexes.

Attachments (1)

trac_9122-cubical-simplicial.patch (12.2 KB) - added by John Palmieri 12 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by John Palmieri

Status: newneeds_review

comment:2 Changed 12 years ago by mhampton

Cc: mhampton added

comment:3 Changed 12 years ago by mhampton

Status: needs_reviewneeds_info

Maybe I am building the docs incorrectly, but it seems kind of sad that the documentation for _simplicial_ and _cubical_ does not show up in the reference manual, and if you look at it in the notebook it is not currently rendered correctly.

Otherwise the functionality appears to be correctly implemented (although I have very little expertise in this area). The flaws in rendering are probably the fault of the notebook code rather than this patch.

comment:4 Changed 12 years ago by John Palmieri

Status: needs_infoneeds_review

Oh, I think it's partly the fault of the patch: the docstrings should start with r""", not just """. Try this new patch.

Changed 12 years ago by John Palmieri

comment:5 Changed 11 years ago by mhampton

Status: needs_reviewpositive_review

All homology tests passed and the documentation looks fixed, so I think this is OK now.

comment:6 Changed 11 years ago by Jeroen Demeyer

Milestone: sage-4.7sage-4.7.1
Reviewers: Marshall Hampton

comment:7 Changed 11 years ago by Jeroen Demeyer

Merged in: sage-4.7.1.alpha2
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.