#9121 closed defect (fixed)
sage-4.4.3.alpha1: set.py doctest failure
Reported by: | William Stein | Owned by: | tbd |
---|---|---|---|
Priority: | blocker | Milestone: | sage-4.4.3 |
Component: | doctest coverage | Keywords: | Sets comparison |
Cc: | Merged in: | sage-4.4.3.alpha3 | |
Authors: | William Stein | Reviewers: | Florent Hivert |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
This test now fails in set.py:
sage: Primes() < Set(QQ) True
Attachments (2)
Change History (10)
comment:1 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Status: | new → needs_review |
Changed 13 years ago by
Attachment: | trac_9121.patch added |
---|
comment:2 Changed 13 years ago by
I actually reported http://trac.sagemath.org/sage_trac/ticket/9004 on that expression - the test has failed for a long time on sage-on-gentoo. I didn't notice the backwardness and did something slightly different, but the backwardness explain a lot of things. I think you should have a look at it and mark one of them a duplicate.
comment:3 Changed 13 years ago by
Milestone: | sage-4.4.4 → sage-4.4.3 |
---|
Changed 13 years ago by
Attachment: | trac_9121-part2.patch added |
---|
comment:4 follow-up: 5 Changed 13 years ago by
fbissey -- you're right. Both of our patches are wrong, but together they are right.
Note that I'm marking this test random, since it is a comparison of types, which is architecture and sage-version dependent.
comment:5 Changed 13 years ago by
Replying to was:
fbissey -- you're right. Both of our patches are wrong, but together they are right.
Note that I'm marking this test random, since it is a comparison of types, which is architecture and sage-version dependent.
Note : trac_9121.patch was already merged in sage-4.4.3.alpha1 only trac_9121-part2.patch needs to be merged... The patch looks good to me I'm waiting for the tests to finish.
comment:6 Changed 13 years ago by
Authors: | → William Stein |
---|---|
Keywords: | Sets comparison added |
Reviewers: | → Florent Hivert |
Status: | needs_review → positive_review |
All tests passed!
comment:7 Changed 13 years ago by
Merged in: | → 4.4.3.alpha3 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:8 Changed 13 years ago by
Merged in: | 4.4.3.alpha3 → sage-4.4.3.alpha3 |
---|
I noticed a bug while looking at the relevant code in cmp:
Notice that the first compare is totally backwards! Interestingly, fixing this does fix the above bug. Patch attached.