Opened 13 years ago
Closed 12 years ago
#9080 closed enhancement (fixed)
add F-distribution support for RealDistribution
| Reported by: | klee | Owned by: | amhou |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-4.7.2 |
| Component: | statistics | Keywords: | |
| Cc: | Merged in: | sage-4.7.2.alpha0 | |
| Authors: | Kwankyu Lee | Reviewers: | Karl-Dieter Crisman |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description
add the F-distribution to the supported distributions for RealDistribution
Attachments (3)
Change History (12)
Changed 13 years ago by
| Attachment: | trac#9080.patch added |
|---|
comment:1 Changed 13 years ago by
| Status: | new → needs_review |
|---|
comment:2 Changed 12 years ago by
| Status: | needs_review → needs_work |
|---|
You may want to rebase this against 4.6.alpha1 if necessary. Also, the commit message should start with Trac 9080 or something like that. Finally, maybe the error message should say that this is not a supported distribution? It's certainly conceivable that there would be one in the literature which isn't yet in Sage or GSL :)
comment:3 Changed 12 years ago by
| Status: | needs_work → needs_review |
|---|
I rebased the patch to the latest release of Sage (4.5.3). It was fun (and sad...) to see all different flavors of the heads of the commit messages used by developers. I followed the one DEMANDED by the developer manual. I changed all the error message as suggested.
Changed 12 years ago by
| Attachment: | trac_9080.patch added |
|---|
revised according to the reviewer's comments
comment:4 follow-up: 5 Changed 12 years ago by
There is a slight inconsistency even in the developer manual. In the section "Producing Patches with Mercurial", "trac xxxx: ..." is suggested while "Trac xxxx: ..." seems to be the official standard.
comment:5 Changed 12 years ago by
Replying to klee:
There is a slight inconsistency even in the developer manual. In the section "Producing Patches with Mercurial", "trac xxxx: ..." is suggested while "Trac xxxx: ..." seems to be the official standard.
You could ask on sage-devel about this - for me, it's not so crucial, but mvngu might have an informed opinion.
Changed 12 years ago by
| Attachment: | trac_9080-rebased.patch added |
|---|
comment:7 Changed 12 years ago by
| Reviewers: | → Karl-Dieter Crisman |
|---|---|
| Status: | needs_review → positive_review |
Positive review. Gives correct values, checked with Wolfram Alpha. Not surprising, since GSL is a very stable library.
But we need a lot more doctests for just about all of these - see #11514.
comment:8 Changed 12 years ago by
| Milestone: | sage-4.7.1 → sage-4.7.2 |
|---|
comment:9 Changed 12 years ago by
| Merged in: | → sage-4.7.2.alpha0 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
The patch adds F-distribution.