Opened 12 years ago

Closed 12 years ago

#9068 closed defect (fixed)

remove redundant sgn function from quadratic_forms/extras

Reported by: cremona Owned by: AlexGhitza
Priority: major Milestone: sage-4.4.4
Component: algebra Keywords: sgn sign
Cc: kcrisman Merged in: sage-4.4.4.alpha0
Authors: John Cremona Reviewers: Alex Ghitza
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

There is a sgn() function defined in sage/quadratic_forms/extras.py which just duplicates the one in sage/functions/generalized.py, so I have removed it and adjusted imports accordingly.

May depend on #7828.

Attachments (1)

trac_9068-sgn.patch (2.6 KB) - added by cremona 12 years ago.
Applies to 4.4.3.alpha0

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by cremona

Applies to 4.4.3.alpha0

comment:1 Changed 12 years ago by cremona

  • Cc kcrisman added
  • Status changed from new to needs_review

comment:2 Changed 12 years ago by AlexGhitza

  • Milestone set to sage-4.4.4
  • Reviewers set to Alex Ghitza
  • Status changed from needs_review to positive_review

Looks good.

comment:3 Changed 12 years ago by mhansen

  • Merged in set to sage-4.4.4.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.