Opened 12 years ago

Closed 11 years ago

#9064 closed enhancement (fixed)

remove p-adic matrix directory

Reported by: was Owned by: jason, was
Priority: minor Milestone: sage-4.5.3
Component: linear algebra Keywords:
Cc: Merged in: sage-4.5.3.rc0
Authors: William Stein Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

There's a single file in matrix/padics and it is an empty init.py.

Says David Roe: "Yeah, oversight.  At some point I was planning on working on p-adic matrices, and I guess the init.py file got put in then.  Since I'm not going to work on it anytime soon, it can safely be removed."

Attachments (1)

trac_9064-remove_padic_matrix.patch (327 bytes) - added by mpatel 11 years ago.
Remove matrix/padics.

Download all attachments as: .zip

Change History (6)

comment:1 follow-up: Changed 11 years ago by was

  • Status changed from new to needs_review

Since the file is empty, I can't do think of any way to actually do this with HG. It seems impossible.

flat:matrix wstein$ hg rm  padics
removing padics/__init__.py
flat:matrix wstein$ 
flat:matrix wstein$ 
flat:matrix wstein$ hg ci
flat:matrix wstein$ hg export ip
abort: unknown revision 'ip'!
flat:matrix wstein$ hg export tip
# HG changeset patch
# User William Stein <wstein@gmail.com>
# Date 1281549848 25200
# Node ID 029114d1f8a76cbd4d88b2a9a28fecadac170205
# Parent  5b338f2e484f2065d3d30d47bc204d6e9ed13d12
trac 9064 -- remove p-adic matrix directory

(see nothing!)

So there is no patch to post, and I take David Roe's statement (above) as a positive review.

So to the release manager merging this, just do the following:

cd SAGE_ROOT/devel/sage/sage/matrix
sage -hg rm  padics
sage -hg ci

and checkin the resulting empty patch. Unfortunately, this won't do anything for people doing "sage -upgrade". Anyway, it's an empty directory so whatever happens is pretty harmless.

comment:2 Changed 11 years ago by was

  • Status changed from needs_review to positive_review

comment:3 Changed 11 years ago by mpatel

  • Authors set to William Stein
  • Reviewers set to David Roe

Changed 11 years ago by mpatel

Remove matrix/padics.

comment:4 in reply to: ↑ 1 Changed 11 years ago by mpatel

Replying to was:

So there is no patch to post, and I take David Roe's statement (above) as a positive review.

I've attached a patch made with the Mercurial queues extension.

comment:5 Changed 11 years ago by mpatel

  • Merged in set to sage-4.5.3.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.