Opened 12 years ago

Last modified 12 years ago

#8988 closed enhancement

Add support for toric varieties — at Version 6

Reported by: novoselt Owned by: AlexGhitza
Priority: major Milestone: sage-4.5.2
Component: algebraic geometry Keywords:
Cc: vbraun, davidloeffler Merged in:
Authors: Andrey Novoseltsev Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by novoselt)

This patch is a part of the following series adding support for cones/fans and toric varieties to Sage:


#8675 - Remove AmbientSpace._constructor and fix consequences

#8682 - Improve AlgebraicScheme_subscheme.__init__ and AmbientSpace._validate

#8694 - Improve schemes printing and LaTeXing

#8934 - Trivial bug in computing faces of non-full-dimensional lattice polytopes

#8936 - Expose facet inequalities for lattice polytopes

#8941 - _latex_ and origin for lattice polytopes

Main patches adding new modules:

#9062 - Add support for toric lattices

#8986 - Add support for convex rational polyhedral cones

#8987 - Add support for rational polyhedral fans

#8988 - Add support for toric varieties

#8989 - Add support for Fano toric varieties

Everything was tested on sage.math using sage-4.4.2.rc0.

Known issues:

  • Applying patch for toric varieties leads to a doctest error in sage.symbolic.random_tests, which I don't quite understand, especially since this patch just adds a new module! The documentation of the failing function says "This function will often raise an error because it tries to create an erroneous expression." I am not sure if this means that its doctest may cause these errors.
  • The last two patches show a doctest coverage error about TestSuite. This doctest does not work yet for other schemes and therefore should not be expected to work for these derived classes (and indeed - it does not work). According to this should not be an obstacle to include these patches.

Change History (7)

comment:1 Changed 12 years ago by novoselt

  • Authors set to Andrey Novoseltsev
  • Description modified (diff)
  • Milestone set to sage-4.4.2
  • Status changed from new to needs_review

comment:2 Changed 12 years ago by novoselt

I have marked this ticket as "needs review" despite of the broken doctest. Since that doctest seems to be unrelated, please review the ticket and state your opinion independently of it, without actually switching to "positive review". If nobody objects, I will shortly post a patch changing that doctest to the new output. As I understand, the purpose of that function is to actually try to "create some mess" and so there is no any meaning in a particular output.

comment:3 Changed 12 years ago by novoselt

Oops, forgot to click replace existing file. Only the second patch should be applied. I have added a more formal reference to "Toric Varieties" book (and I checked with David Cox that it is OK to put a link to the draft). I have also moved the kaehler_cone function from Fano toric varieties to this patch.

comment:4 Changed 12 years ago by novoselt

  • Status changed from needs_review to needs_work

I will make some adjustments to modules on which this patch depends, which may cause some changes in this patch as well. See

comment:5 Changed 12 years ago by novoselt

A couple little changes to account for changes in previous patches. Plus the fix for the broken doctest in symbolic.

comment:6 Changed 12 years ago by novoselt

  • Description modified (diff)
Note: See TracTickets for help on using tickets.