Changes between Version 1 and Version 3 of Ticket #8986


Ignore:
Timestamp:
05/28/10 21:39:29 (12 years ago)
Author:
novoselt
Comment:

New version of the patch depends on #9062 and actually makes some improvements to toric lattices. Switch of caching technique to allow efficient extension of class hierarchy is still pending.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #8986

    • Property Status changed from needs_review to needs_work
    • Property Cc vbraun added
  • Ticket #8986 – Description

    v1 v3  
    1717Main patches adding new modules:
    1818
     19#9062 - Add support for toric lattices
     20
    1921#8986 - Add support for convex rational polyhedral cones
    2022
     
    2628
    2729Everything was tested on sage.math using sage-4.4.2.rc0.
    28 
    29 Known issues:
    30 
    31 - Applying patch for toric varieties leads to a doctest error in {{{sage.symbolic.random_tests}}}, which I don't quite understand, especially since this patch just adds a new module! The documentation of the failing function says "This function will often raise an error because it tries to create an erroneous expression." I am not sure if this means that its doctest may cause these errors.
    32 
    33 - The last two patches show a doctest coverage error about {{{TestSuite}}}. This doctest does not work yet for other schemes and therefore should not be expected to work for these derived classes (and indeed - it does not work). According to
    34 http://groups.google.com/group/sage-devel/browse_thread/thread/a42ace80078373b4
    35 this should not be an obstacle to include these patches.