Opened 11 years ago
Closed 11 years ago
#8970 closed defect (fixed)
conversion of integer mods to Gap
Reported by: | davidloeffler | Owned by: | AlexGhitza |
---|---|---|---|
Priority: | major | Milestone: | sage-4.5.2 |
Component: | algebra | Keywords: | |
Cc: | Merged in: | sage-4.5.2.alpha0 | |
Authors: | David Loeffler | Reviewers: | Robert Miller |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
The code to convert elements of integer mod rings into Gap elements is needlessly complicated, and also very broken when the modulus isn't prime.
Attachments (1)
Change History (4)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
Here's a patch, which takes care of conversion in both directions.
comment:2 Changed 11 years ago by
- Reviewers set to Robert Miller
- Status changed from needs_review to positive_review
Looks good to me.
comment:3 Changed 11 years ago by
- Merged in set to sage-4.5.2.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
patch against 4.4.1