Opened 11 years ago

Closed 10 years ago

#8948 closed enhancement (fixed)

add thin space between vector entries

Reported by: jason Owned by: jason, was
Priority: minor Milestone: sage-4.6.2
Component: linear algebra Keywords:
Cc: rbeezer Merged in: sage-4.6.2.alpha3
Authors: Jason Grout, Rob Beezer Reviewers: Rob Beezer, Andrey Novoseltsev
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This patch adds a thin space between vector entries, which helps distinguish the entries from each other, especially when there are symbolic expressions, so the entries already may have thin spaces in them.

Attachments (2)

trac-8948-vector-printing-space.patch (918 bytes) - added by jason 11 years ago.
trac_8948-vector-printing-doctests.patch (6.6 KB) - added by rbeezer 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by jason

comment:1 Changed 10 years ago by jason

  • Cc rbeezer added
  • Status changed from new to needs_work

Rob, you might be interested in this slight improvement to linear algebra latexing.

Maybe this ticket only needs a doctest to be ready for review?

comment:2 Changed 10 years ago by rbeezer

  • Reviewers set to Rob Beezer

Yep, code looks good. I always put a thin space into my vectors, so this will be nice to have automatically. Doctests are updated, made two necessary fixes in the symbolic-callable tests. Running tests right now and will report back.

Changed 10 years ago by rbeezer

comment:3 Changed 10 years ago by rbeezer

  • Status changed from needs_work to needs_review
  • Work issues doctests deleted

Attachment is totally doctests that needed fixing, plus one new one. No change to the code. I'm fine with a positive review on the code once somebody checks my doctest changes.

comment:4 Changed 10 years ago by novoselt

  • Authors changed from Jason Grout to Jason Grout, Rob Beezer
  • Reviewers changed from Rob Beezer to Rob Beezer, Andrey Novoseltsev
  • Status changed from needs_review to positive_review

Doctests changes looks good, I also think that it will be a nice improvement!

comment:5 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.6.2.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.