Opened 11 years ago

Closed 11 years ago

#8921 closed enhancement (fixed)

Extend cross product to 7d

Reported by: bwonderly Owned by: jason, was
Priority: minor Milestone: sage-4.4.4
Component: linear algebra Keywords:
Cc: jason, rbeezer Merged in: sage-4.4.4.alpha0
Authors: Billy Wonderly Reviewers: Jason Grout
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The cross product is defined for 7D, this patch allows for that functionality.

Attachments (1)

trac_8921_7d_cross_product.patch (5.3 KB) - added by bwonderly 11 years ago.

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by bwonderly

comment:1 follow-up: Changed 11 years ago by rbeezer

Jason,

I need to double-check the tests this afternoon, Billy is getting some known failures.

I'll post here when full tests pass.

Rob

comment:2 in reply to: ↑ 1 Changed 11 years ago by rbeezer

  • Status changed from new to needs_review

Replying to rbeezer:

I'll post here when full tests pass.

This passed all tests on my machine, so I think it is ready for a review.

Rob

comment:3 Changed 11 years ago by jason

  • Reviewers set to Jason Grout
  • Status changed from needs_review to positive_review

tests pass on affected file, the formula checks out with wikipedia, and the properties are illustrated with the doctests.

Positive review! Very nice! Thanks for your work, Billy!

comment:4 Changed 11 years ago by jason

  • Cc rbeezer added

comment:5 Changed 11 years ago by mhansen

  • Merged in set to sage-4.4.4.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.