Opened 10 years ago

Last modified 10 years ago

#8910 closed defect

Have CombinatorialClass inherits from Parent — at Version 4

Reported by: hivert Owned by: hivert
Priority: major Milestone: sage-4.4.4
Component: combinatorics Keywords: CombinatorialClass Parent
Cc: sage-combinat Merged in:
Authors: Florent Hivert Reviewers: Nicolas M. Thiéry
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by hivert)

This is the first step of the cleanup of the combinatorial classes see

http://trac.sagemath.org/sage_trac/wiki/SageCombinatRoadMap

Patch in progress and review on sage-combinat queue.

Depend on #8881

Change History (6)

comment:1 Changed 10 years ago by hivert

  • Description modified (diff)
  • Reviewers set to Nicolas M. Thiéry
  • Status changed from new to needs_work

comment:2 follow-up: Changed 10 years ago by hivert

  • Keywords CombinatorialClass Parent added
  • Status changed from needs_work to needs_review

The patch has been reviewed by Nicolas on the patch queue. I folded the review patches:

$ hg qgoto trac_8910-subsets_an_element-fh.patch
$ hg qfold trac_8910-subsets_an_element-review-nt.patch
$ hg qfold trac_8910-subsets_an_element-review-review-fh.patch

And Nicolas said by e-mail

> Dès que j'ai ton feu vert, je folde tout, et met la positive review sur trac.

Feu vert!

Meaning: (FH) as soon as I have your green light I fold the whole bunch, and set positive review on trac. (Answer from Nicolas) Green Light.

Therefore I allowed myself to put the positive review.

comment:3 in reply to: ↑ 2 Changed 10 years ago by hivert

  • Status changed from needs_review to positive_review

Meaning: (FH) as soon as I have your green light I fold the whole bunch, and set positive review on trac. (Answer from Nicolas) Green Light.

Therefore I allowed myself to put the positive review.

Done

comment:4 Changed 10 years ago by hivert

  • Description modified (diff)

I forgot to tell: depend on #8881 (review in progress. Should be done soon).

Changed 10 years ago by hivert

Note: See TracTickets for help on using tickets.