Opened 13 years ago
Closed 13 years ago
#8910 closed defect (fixed)
Have CombinatorialClass inherits from Parent
Reported by: | hivert | Owned by: | hivert |
---|---|---|---|
Priority: | major | Milestone: | sage-4.4.4 |
Component: | combinatorics | Keywords: | CombinatorialClass Parent |
Cc: | sage-combinat | Merged in: | sage-4.4.4.alpha0 |
Authors: | Florent Hivert | Reviewers: | Nicolas M. Thiéry |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
This is the first step of the cleanup of the combinatorial classes see
http://trac.sagemath.org/sage_trac/wiki/SageCombinatRoadMap
Depend on #8881
Apply the two patches:
Attachments (2)
Change History (9)
comment:1 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Reviewers: | → Nicolas M. Thiéry |
Status: | new → needs_work |
Changed 13 years ago by
Attachment: | trac_8910-combinatorial_class_parent-fh.patch added |
---|
comment:2 follow-up: 3 Changed 13 years ago by
Keywords: | CombinatorialClass Parent added |
---|---|
Status: | needs_work → needs_review |
comment:3 Changed 13 years ago by
Status: | needs_review → positive_review |
---|
Meaning: (FH) as soon as I have your green light I fold the whole bunch, and set positive review on trac. (Answer from Nicolas) Green Light.
Therefore I allowed myself to put the positive review.
Done
comment:4 Changed 13 years ago by
Description: | modified (diff) |
---|
I forgot to tell: depend on #8881 (review in progress. Should be done soon).
Changed 13 years ago by
Attachment: | trac_8910-subsets_an_element-fh.patch added |
---|
comment:5 Changed 13 years ago by
Description: | modified (diff) |
---|
comment:7 Changed 13 years ago by
Merged in: | → sage-4.4.4.alpha0 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
The patch has been reviewed by Nicolas on the patch queue. I folded the review patches:
And Nicolas said by e-mail
Meaning: (FH) as soon as I have your green light I fold the whole bunch, and set positive review on trac. (Answer from Nicolas) Green Light.
Therefore I allowed myself to put the positive review.