Opened 10 years ago

Closed 10 years ago

#8902 closed defect (fixed)

Subsets element construction is broken

Reported by: hivert Owned by: hivert
Priority: major Milestone: sage-4.4.4
Component: combinatorics Keywords: Subsets constructor
Cc: sage-combinat Merged in: sage-4.4.4.alpha0
Authors: Florent Hivert Reviewers: Nicolas M. Thiéry
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by nthiery)

sage: S2 = Subsets(2)
sage: S2([])
<type 'sage.structure.parent.Set_generic'>
sage: S2([1])
<type 'sage.structure.parent.Set_generic'>

The attached patch fixes this.

Attachments (1)

trac_8902-subsets_call_fix-fh.patch (3.8 KB) - added by hivert 10 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by hivert

  • Authors set to Florent Hivert
  • Status changed from new to needs_review

Note: This is a temporary fixes before the cleanup of combinat (categorification of the combinatorial classes is done).

comment:2 Changed 10 years ago by hivert

  • Cc sage-combinat added
  • Owner changed from sage-combinat to hivert

Changed 10 years ago by hivert

comment:3 Changed 10 years ago by hivert

  • Reviewers set to Nicolas M. Thiéry

Nicolas on sage-combinat series file:

trac_8902-subsets_call_fix-fh.patch               # Positive review, assuming tests pass (NT)

I got a all test passes on massena.

Note: the category related problem we discussed on the phone is postponed until #8910 in the patch trac_8910-subsets_an_element-fh.patch.

If you are ok with that can you put a positive review ?

comment:4 Changed 10 years ago by nthiery

  • Description modified (diff)
  • Status changed from needs_review to positive_review

comment:5 Changed 10 years ago by mhansen

  • Merged in set to sage-4.4.4.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.