Opened 12 years ago

Closed 10 years ago

#8886 closed enhancement (fixed)

tutorial on Python object and classes

Reported by: mvngu Owned by: hivert
Priority: major Milestone: sage-4.7.2
Component: documentation Keywords:
Cc: leif, nthiery Merged in: sage-4.7.2.alpha4
Authors: Florent Hivert, Minh Van Nguyen Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #11251, #11632 Stopgaps:

Status badges

Description (last modified by jdemeyer)

As the subject says. See this sage-devel thread for some background information. This should be coordinated with #8470.

Apply:

  1. trac_8886-objects-classes_tutorial-fh-jhp-rebased.patch

Attachments (6)

trac_8886-config.patch (6.1 KB) - added by mvngu 12 years ago.
trac_8886-objects-classes_tutorial-fh.patch (78.3 KB) - added by hivert 10 years ago.
trac_8886-delta.patch (18.3 KB) - added by jhpalmieri 10 years ago.
trac_8886-objects-classes_tutorial-jhp.patch (79.5 KB) - added by jhpalmieri 10 years ago.
trac_8886-objects-classes_tutorial-fh-jhp.patch (79.5 KB) - added by hivert 10 years ago.
trac_8886-objects-classes_tutorial-fh-jhp-rebased.patch (79.5 KB) - added by jdemeyer 10 years ago.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 12 years ago by hivert

  • Cc hivert removed
  • Owner changed from mvngu to hivert

I'm preparing a patch on sage-combinat queue... I took ownership of the ticket (to have it in the my ticket report).

Florent

Changed 12 years ago by mvngu

comment:2 Changed 12 years ago by mvngu

  • Authors set to Minh Van Nguyen
  • Description modified (diff)

The patch trac_8886-config.patch contains the Sphinx configuration and build files. Such files are required to get Sphinx to build documents in the category "Thematic Tutorials". When #8468 was merged, the prerequisites listed on that ticket were not merged at all. This meant that the relevant build and configuration files did not go into Sage 4.4.1. The patch trac_8886-config.patch is an attempt to fix this. You should apply this patch prior to adding any new documents to "Thematic Tutorials".

comment:3 follow-up: Changed 12 years ago by mjordan7

I have sage 4.3.5 and have been manually applying the doc patches. This one does not apply even though I have the prereqs. I have applied 8464, 8465, 8469, and 8442. Is that the wrong order? ~Mark

comment:4 in reply to: ↑ 3 Changed 12 years ago by mvngu

Replying to mjordan7:

I have sage 4.3.5 and have been manually applying the doc patches. This one does not apply even though I have the prereqs.

I didn't mention that you need to apply patches on top of Sage 4.4.1. The patches on this ticket and the prequisite ticket were produced on top of Sage 4.4.1. Sorry for the inconvenience.

comment:5 Changed 12 years ago by mvngu

  • Description modified (diff)

comment:6 Changed 11 years ago by jhpalmieri

If #8465 is merged, then trac_8886-config.patch is no longer needed.

comment:7 Changed 10 years ago by hivert

  • Authors changed from Minh Van Nguyen to Florent Hivert, Minh Van Nguyen
  • Dependencies set to 11251
  • Description modified (diff)
  • Status changed from new to needs_review

comment:8 Changed 10 years ago by hivert

  • Description modified (diff)

comment:9 follow-up: Changed 10 years ago by jhpalmieri

  • Dependencies changed from 11251 to #11251, #11632
  • Description modified (diff)
  • Reviewers set to John Palmieri

There is a mistake in thematic_tutorials/conf.py which prevents math like \QQ from being rendered properly. This is fixed in #11632, so I've made that a dependency for this ticket. (Please review it!)

I've fixed some typos and grammatical errors. See the "delta" patch for the differences between my patch and the previous one. I'm happy with what you've done, so if you're happy with my changes, give the ticket a positive review.

Changed 10 years ago by jhpalmieri

Changed 10 years ago by jhpalmieri

comment:10 in reply to: ↑ 9 Changed 10 years ago by hivert

  • Status changed from needs_review to positive_review

Replying to jhpalmieri:

There is a mistake in thematic_tutorials/conf.py which prevents math like \QQ from being rendered properly. This is fixed in #11632, so I've made that a dependency for this ticket. (Please review it!)

I'll do it.

I've fixed some typos and grammatical errors. See the "delta" patch for the differences between my patch and the previous one. I'm happy with what you've done, so if you're happy with my changes, give the ticket a positive review.

Thanks for correcting my bad English. I'm mostly happy with your change. The only remark I have is the removal of the link :ref:`tutorial-programming-python`. It is an up coming tutorial which is not yet fully finished. I'm creating a new ticket (#11633) and reinstating the pointer there.

Thanks for your careful review.

Florent

comment:11 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-4.7.1 to sage-pending

comment:12 Changed 10 years ago by leif

  • Cc leif added

comment:13 Changed 10 years ago by hivert

  • Status changed from positive_review to needs_work

Nicolas pointed out the following typo:

line 14:

functions (see the "Programming" section of the Sage tutorial) -- but now further +knowledge

"now" should be "no". I'm updating a corrected patch.

comment:14 follow-up: Changed 10 years ago by hivert

  • Cc nthiery added
  • Description modified (diff)
  • Status changed from needs_work to needs_review

New new patch is updated it should be reviewed. The diff from the preceding patch is:

1.1 --- a/trac_8886-objects-classes_tutorial-fh-jhp.patch Wed Aug 31 09:50:46 2011 +0200 
1.2 +++ b/trac_8886-objects-classes_tutorial-fh-jhp.patch Wed Aug 31 11:37:04 2011 +0200 
1.3 @@ -890,7 +890,7 @@ 
1.4 +This tutorial is an introduction to object-oriented programming in Python and 
1.5 +Sage. It requires basic knowledge about imperative/procedural programming (the 
1.6 +most common programming style) -- that is, conditional instructions, loops, 
1.7 -+functions (see the "Programming" section of the Sage tutorial) -- but now further knowledge 
1.8 ++functions (see the "Programming" section of the Sage tutorial) -- but no further knowledge 
1.9 +about objects and classes is assumed. It is designed as an alternating 
1.10 +sequence of formal introduction and exercises. :ref:`solutions` are given at 
1.11 +the end. 

comment:15 in reply to: ↑ 14 Changed 10 years ago by nthiery

  • Status changed from needs_review to positive_review

Replying to hivert:

New new patch is updated it should be reviewed. The diff from the preceding patch is:

1.1 --- a/trac_8886-objects-classes_tutorial-fh-jhp.patch Wed Aug 31 09:50:46 2011 +0200 
1.2 +++ b/trac_8886-objects-classes_tutorial-fh-jhp.patch Wed Aug 31 11:37:04 2011 +0200 
1.3 @@ -890,7 +890,7 @@ 
1.4 +This tutorial is an introduction to object-oriented programming in Python and 
1.5 +Sage. It requires basic knowledge about imperative/procedural programming (the 
1.6 +most common programming style) -- that is, conditional instructions, loops, 
1.7 -+functions (see the "Programming" section of the Sage tutorial) -- but now further knowledge 
1.8 ++functions (see the "Programming" section of the Sage tutorial) -- but no further knowledge 
1.9 +about objects and classes is assumed. It is designed as an alternating 
1.10 +sequence of formal introduction and exercises. :ref:`solutions` are given at 
1.11 +the end. 

I suggested that tiny change, so positive review on it :-)

comment:16 Changed 10 years ago by jdemeyer

  • Description modified (diff)
  • Milestone changed from sage-pending to sage-4.7.2

comment:17 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.7.2.alpha4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.