Opened 8 years ago

Closed 7 years ago

#8876 closed enhancement (fixed)

Allows triangular morphisms to have domain and codomain with different index sets

Reported by: hivert Owned by: hivert
Priority: major Milestone: sage-4.4.4
Component: categories Keywords: Triangular Morphisms
Cc: Merged in: sage-4.4.4.alpha0
Authors: Florent Hivert Reviewers: Jason Bandlow
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by hivert)

Currently triangular morphisms required to have domain and codomain with the same index sets. The patch remove this limitation by having TriangularMorphism accept a new argument inverse_on_support. It is supposed to be a function r : J |--> I returning the leading term i from the one of j = on_basis(i). This is used by: preimage and section.

I also wrote the methods co_kernel_projection, co_reduced, and _test_triangular.

Depend on #8881 and #8742, Apply patch in that order:

Attachments (2)

trac_8876-triangular_morphisms_improve-fh.patch (27.1 KB) - added by hivert 7 years ago.
trac_8876-reviewer_patch-jb.patch (11.3 KB) - added by jbandlow 7 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by hivert

  • Description modified (diff)
  • Status changed from new to needs_review

Changed 7 years ago by jbandlow

comment:2 Changed 7 years ago by jbandlow

  • Reviewers set to Jason Bandlow

Hi Florent, I found some issues with the file as I was going through it, which I've fixed in the attached reviewer patch. (Many were probably my fault to begin with.) Everything else looks good to me. If you approve my reviewer patch and verify that all tests pass on massena without prereqs, you can set a positive review. (I will post my reviewer patch on the combinat queue immediately below yours right now.)

comment:3 Changed 7 years ago by hivert

  • Description modified (diff)
  • Status changed from needs_review to positive_review

Everything was ok with the following patch applied:

trac_8881-functorial_constructions-nt.patch
trac_8742-lazy_format-fh.patch
trac_8742-lazy_format-review-nt.patch
trac_8876-triangular_morphisms_improve-fh.patch
trac_8876-reviewer_patch-jb.patch

Thanks for the review and the corrections. Your patch is good. Positive review

comment:4 Changed 7 years ago by mhansen

  • Merged in set to sage-4.4.4.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.