Opened 13 years ago

Closed 13 years ago

#8856 closed enhancement (fixed)

Reinstate cached one in algebra_with_basis

Reported by: Florent Hivert Owned by: Florent Hivert
Priority: major Milestone: sage-4.4.2
Component: categories Keywords: cached one_basis
Cc: Sage Combinat CC user Merged in: sage-4.4.2.alpha0
Authors: Florent Hivert Reviewers: Nicolas M. Thiéry
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

From algebra_with_basis.py:

#@cached_method   # todo: reinstate once #5843 is fixed
def one_from_one_basis(self):
    """
    Returns the one of the algebra, as per
            ``Monoids.ParentMethods.one``
    [...]
    """
    return self.monomial(self.one_basis()) #.

So I'm removing the comment since #5843 is fixed.

Attachments (1)

trac_8856-cached_one_basis-fh.patch (1.6 KB) - added by Florent Hivert 13 years ago.

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by Florent Hivert

comment:1 Changed 13 years ago by Florent Hivert

Status: newneeds_review

Ready for review...

comment:2 Changed 13 years ago by Nicolas M. Thiéry

Reviewers: Nicolas M. Thiéry

I had ask for this change, and the extra tests are good. Thanks for handling this!

Please double check that all test pass (they should), and then you can put a positive review on my behalf.

comment:3 Changed 13 years ago by Florent Hivert

Status: needs_reviewpositive_review

I got a all test on massena (upto usual synchro problem which I rechecked...)...

comment:4 Changed 13 years ago by Minh Van Nguyen

Merged in: sage-4.4.2.alpha0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.