Opened 12 years ago

Closed 12 years ago

#8827 closed defect (fixed)

Cache heights of points on elliptic curves

Reported by: robertwb Owned by: cremona
Priority: major Milestone: sage-4.4.2
Component: elliptic curves Keywords:
Cc: Merged in: sage-4.4.2.alpha0
Authors: Robert Bradshaw Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

I've found myself taking the height of the same points over and over again, and have been starting to wish they were cached (especially over number fields). This patch does it.

Attachments (1)

8827-point-height-cache.patch (1.9 KB) - added by robertwb 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by robertwb

comment:1 Changed 12 years ago by robertwb

  • Status changed from new to needs_review

comment:2 Changed 12 years ago by cremona

  • Authors set to Robert Bradshaw
  • Reviewers set to John Cremona
  • Status changed from needs_review to positive_review

I can't believe that we never cached heights before! (Perhaps we did when they were only implemented over QQ, but I'm not going to go back and check).

Note that this is one case where the caching is slightly less trivial since we need to recompute of the desired precision is > the cached precision. The patched code does that properly.

Applies fine to 4.4 and all elliptic_curves tests pass.

comment:3 Changed 12 years ago by mvngu

  • Merged in set to sage-4.4.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.