Changes between Version 62 and Version 83 of Ticket #8800


Ignore:
Timestamp:
Feb 26, 2011, 11:29:16 AM (12 years ago)
Author:
lftabera
Comment:

I have tested with sage-4.6.1.rc0 the documentation builds and looks good. The bugs have been corrected and the patch introduces some very nice features. Good work. Positive review to Simon's patch.

However, I have added a referee patch with some minor changes in the documentation. I have eliminated some latex code that, in my opinion, made the documentation harder to read.

Simon, could you look at my patch? If you feel it is ok, put a positive review.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #8800

    • Property Status changed from needs_work to needs_review
    • Property Work issues changed from change 32-bit test; remove forgetful coercion to
    • Property Milestone changed from sage-4.6.2 to sage-4.7
    • Property Reviewers changed from to Luis Felipe Tabera Alonso

  • Ticket #8800 – Description

    v62 v83  
    521521
    522522  Note that I also had to change some arithmetic stuff in the `_tate` method of elliptic curves: The old implementation relied on the assumption that fractional ideals in an embedded field and in a non-embedded field can't be equal. This assumption should still hold (since we do not introduce forgetful coercion), but I think it is OK to keep the change in _tate.
     523
     524Apply:
     525
     5261. 8800_functor_pushout_doc_and_fixes.patch[BR]
     5272. referee.patch