Opened 9 years ago

Closed 9 years ago

#8798 closed defect (fixed)

Duplicate version of feedback_arc_set and feedback_vertex_set

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.4.2
Component: graph theory Keywords:
Cc: mvngu Merged in: sage-4.4.2.alpha0
Authors: Nathann Cohen Reviewers: Minh Van Nguyen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mvngu)

Here is the problem :

~/sage/sage-doc/sage/graphs$ grep -e "def.*eedback" *
digraph.py:    def feedback_edge_set(self,value_only=False):
digraph.py:    def feedback_vertex_set(self,value_only=False):
generic_graph.py:    def feedback_edge_set(self,value_only=False):
generic_graph.py:    def feedback_vertex_set(self,value_only=False):
~/sage/sage-doc/sage/graphs$ 

Prerequisite: #8786

Apply:

Attachments (2)

trac_8798.patch (9.4 KB) - added by ncohen 9 years ago.
trac_8798-rebased.patch (9.5 KB) - added by mvngu 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by ncohen

comment:1 Changed 9 years ago by ncohen

  • Status changed from new to needs_review

And here is the patch ! This code would not work for undirected graphs anyway :-)

Nathann

Changed 9 years ago by mvngu

comment:2 Changed 9 years ago by mvngu

  • Authors set to Nathann Cohen
  • Description modified (diff)
  • Reviewers set to Minh Van Nguyen

The patch trac_8798.patch is OK by me. However, it would likely conflict with #8786. So trac_8798-rebased.patch is a rebase of trac_8798.patch on top of #8786. Someone other than myself needs to check the rebased patch. If it's OK, then the whole ticket is good to go.

comment:3 Changed 9 years ago by ncohen

  • Status changed from needs_review to positive_review

Checked ! Thank you for your help ! :-)

Nathann

comment:4 Changed 9 years ago by mvngu

  • Merged in set to sage-4.4.2.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.