Opened 10 years ago
Closed 10 years ago
#8798 closed defect (fixed)
Duplicate version of feedback_arc_set and feedback_vertex_set
Reported by: | ncohen | Owned by: | jason, ncohen, rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-4.4.2 |
Component: | graph theory | Keywords: | |
Cc: | mvngu | Merged in: | sage-4.4.2.alpha0 |
Authors: | Nathann Cohen | Reviewers: | Minh Van Nguyen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Here is the problem :
~/sage/sage-doc/sage/graphs$ grep -e "def.*eedback" * digraph.py: def feedback_edge_set(self,value_only=False): digraph.py: def feedback_vertex_set(self,value_only=False): generic_graph.py: def feedback_edge_set(self,value_only=False): generic_graph.py: def feedback_vertex_set(self,value_only=False): ~/sage/sage-doc/sage/graphs$
Prerequisite: #8786
Apply:
Attachments (2)
Change History (6)
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
Changed 10 years ago by
comment:2 Changed 10 years ago by
- Description modified (diff)
- Reviewers set to Minh Van Nguyen
The patch trac_8798.patch is OK by me. However, it would likely conflict with #8786. So trac_8798-rebased.patch is a rebase of trac_8798.patch on top of #8786. Someone other than myself needs to check the rebased patch. If it's OK, then the whole ticket is good to go.
comment:3 Changed 10 years ago by
- Status changed from needs_review to positive_review
Checked ! Thank you for your help ! :-)
Nathann
comment:4 Changed 10 years ago by
- Merged in set to sage-4.4.2.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
Merged trac_8798-rebased.patch.
Note: See
TracTickets for help on using
tickets.
And here is the patch ! This code would not work for undirected graphs anyway :-)
Nathann