Opened 11 years ago

Closed 11 years ago

#8796 closed enhancement (fixed)

clean up documentation of logic/propcalc.py

Reported by: mvngu Owned by: mvngu
Priority: major Milestone: sage-4.4.4
Component: documentation Keywords:
Cc: Merged in: sage-4.4.4.alpha0
Authors: Minh Van Nguyen Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mvngu)

As the subject says. This needs to be coordinated with #8797.

Attachments (1)

trac_8796-propcalc-clean-ups.patch (10.5 KB) - added by mvngu 11 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by mvngu

  • Description modified (diff)

Changed 11 years ago by mvngu

comment:2 Changed 11 years ago by mvngu

  • Authors set to Minh Van Nguyen
  • Status changed from new to needs_review

Changes in the patch include:

  • Add sage/logic/propcalc.py to the reference manual.
  • Remove tab characters.
  • Clean-ups in accordance with PEP 008.

comment:3 Changed 11 years ago by ncohen

  • Status changed from needs_review to positive_review

Nice patch. Nothing to complain about :-)

Nathann

comment:4 Changed 11 years ago by leif

"Parentheses may be used to explicitly show order of operation."

I usually use brackets to express (i.e. force) [desired/intended] "order of operation", too. ;-)

"... variables that consist of a leading letter and trailing underscores and alphanumerics" sounds a bit strange.

I'd say "... whose names can be made up of alphanumerics and underscores but must start with a letter" or something like that.

[Haven't applied the patch yet.]

comment:5 Changed 11 years ago by mhansen

  • Merged in set to sage-4.4.4.alpha0
  • Resolution set to fixed
  • Reviewers set to Nathann Cohen
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.