Opened 10 years ago
Closed 10 years ago
#8786 closed defect (fixed)
graph.py: autogenerated broken links to Wikipedia
Reported by: | was | Owned by: | mvngu |
---|---|---|---|
Priority: | major | Milestone: | sage-4.4.2 |
Component: | documentation | Keywords: | |
Cc: | Merged in: | sage-4.4.2.alpha0 | |
Authors: | Minh Van Nguyen, Nathann Cohen | Reviewers: | Minh Van Nguyen, Nathann Cohen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
This is in devel/sage/sage/graphs/graph.py:
class Graph(GenericGraph): r""" Undirected graph. A graph is a set of vertices connected by edges (cf. http://en.wikipedia.org/wiki/Graph_(mathematics) ).
If you look at http://sagemath.org/doc/reference/sage/graphs/graph.html and search for "mathematics", then click the link, you'll see it is broken. Fix this by:
- fixing sphinx? too tricky, maybe
- finding sphinx docs and figuring out how to explicitly specify a URL.
Apply patches in the following order:
Attachments (4)
Change History (11)
comment:1 Changed 10 years ago by
- Summary changed from in graph.py, there is an autogenerated broken link to Wikipedia. replace it by something not autogenerated that works (probably trivial), or fix the url parser in sphinx (really hard) to graph.py: autogenerated broken links to Wikipedia
Changed 10 years ago by
comment:2 Changed 10 years ago by
- Status changed from new to needs_review
The attached patch should fix the broken links in graph.py
to Wikipedia. Any URL can be encapsulated using the markup:
`descriptive-name <valid-URL>`_
comment:3 Changed 10 years ago by
And here are a few more corrections (to be applied on top of Minh's)... Some were not a problem as they contained no parenthesis, but as I had an Emacs macro available... :-)
By the way, I noticed something funny while working on this patch :
~/sage/sage-doc/sage/graphs$ grep -e "def.*eedback" * digraph.py: def feedback_edge_set(self,value_only=False): digraph.py: def feedback_vertex_set(self,value_only=False): generic_graph.py: def feedback_edge_set(self,value_only=False): generic_graph.py: def feedback_vertex_set(self,value_only=False): ~/sage/sage-doc/sage/graphs$
It must have occurred during the splitting of graph.py... I'll create another ticket to take care of it :-)
Nathann
Changed 10 years ago by
Changed 10 years ago by
Changed 10 years ago by
comment:4 follow-up: ↓ 5 Changed 10 years ago by
- Description modified (diff)
- Reviewers set to Minh Van Nguyen
The patch trac_8786-other_fixes.2.patch is the same as trac_8786-other_fixes.patch, but with the ticket number in its commit message. The reviewer patch trac_8786-reviewer.patch contains the following changes:
- The patch trac_8786-other_fixes.2.patch does some fixes about broken links. But it removes the context about why we need such links. Restore that context.
- Some links in trac_8786-other_fixes.2.patch do not link to a Wikipedia article. Correct such links to point to Wikipedia articles.
So only the following patches now need review by anyone but me:
comment:5 in reply to: ↑ 4 Changed 10 years ago by
- Status changed from needs_review to positive_review
So only the following patches now need review by anyone but me:
Then let this ticket be positively reviewed ! The patches are to be applied in this order :
And there is nothing wrong to report on alpha2. And I did not notice any other link we could have missed in the documentation :-)
Thank you very much, Minh !!
Nathann
comment:6 Changed 10 years ago by
- Reviewers changed from Minh Van Nguyen to Minh Van Nguyen, Nathann Cohen
comment:7 Changed 10 years ago by
- Merged in set to sage-4.4.2.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
Merged in this order:
based on Sage 4.4