#8775 closed defect (fixed)
Bug in conjugate of symbolic ring
Reported by: | kcrisman | Owned by: | burcin |
---|---|---|---|
Priority: | critical | Milestone: | sage-4.6.1 |
Component: | symbolics | Keywords: | pynac |
Cc: | Merged in: | sage-4.6.1.alpha1 | |
Authors: | Burcin Erocal | Reviewers: | Luis Felipe Tabera Alonso |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
From http://groups.google.com/group/sage-devel/browse_thread/thread/9f941378a95c0191:
sage: a = sqrt(-3) sage: a sqrt(-3) sage: a.conjugate() sqrt(-3) sage: bool(a==a.conjugate()) True
Could this be related to #6244? Anyway, presumably conjugate should remain unevaluated on this sort of thing, while still being evaluated on things like a+I or 33.
Attachments (3)
Change History (13)
comment:1 Changed 10 years ago by
- Report Upstream changed from N/A to Not yet reported upstream; Will do shortly.
comment:2 Changed 10 years ago by
- Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. Little or no feedback.
Changing upstream report - too early for feedback at this point.
comment:3 Changed 10 years ago by
- Keywords pynac added
- Status changed from new to needs_review
comment:4 follow-up: ↓ 5 Changed 10 years ago by
- Status changed from needs_review to needs_work
For some reason, although Sage 4.4.4.alpha0 has pynac-0.2.0.p3
---------------------------------------------------------------------- | Sage Version 4.4.4.alpha0, Release Date: 2010-06-07 | | Type notebook() for the GUI, and license() for information. | ---------------------------------------------------------------------- ********************************************************************** * * * Warning: this is a prerelease version, and it may be unstable. * * * ********************************************************************** sage: N(sqrt(-2),200) 8.0751148893563733350506651837615871941533119425962889089783e-62 + 1.4142135623730950488016887242096980785696718753769480731767*I sage: conjugate(sqrt(-3)) sqrt(-3)
Did this change not end up making it into the Pynac package after all? According to http://pynac.sagemath.org/hg/rev/60acd6985820, it should be in there, but now I find it hard to explain the above.
comment:5 in reply to: ↑ 4 Changed 10 years ago by
Replying to kcrisman:
Did this change not end up making it into the Pynac package after all? According to http://pynac.sagemath.org/hg/rev/60acd6985820, it should be in there, but now I find it hard to explain the above.
That patched was backed out since it caused some problems with doctests in sage/rings/qqbar.py
.
I merged the upstream patch from GiNaC fixing this problem in the latest version of pynac. I will upload a new patch with doctest fixes later.
comment:6 Changed 10 years ago by
- Report Upstream changed from Reported upstream. Little or no feedback. to N/A
- Status changed from needs_work to needs_review
I uploaded a new patch to add doctests for the fixes in Pynac. Only attachment:trac_8775-conjugate.take2.patch should be applied.
This depends on #9901.
comment:7 Changed 10 years ago by
- Reviewers set to Luis Felipe Tabera
- Status changed from needs_review to positive_review
The issue seems to be solved. I have tried other examples and it works as expected. The doctest passes. Positive review
comment:8 Changed 10 years ago by
- Status changed from positive_review to needs_work
There is a typo in the ticket number in the commit message :-)
comment:9 Changed 10 years ago by
- Merged in set to sage-4.6.1.alpha1
- Resolution set to fixed
- Status changed from needs_work to closed
comment:10 Changed 10 years ago by
- Reviewers changed from Luis Felipe Tabera to Luis Felipe Tabera Alonso
From Burcin Erocal on the same thread:
I'm changing this to "not yet reported upstream".