Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#8774 closed defect (fixed)

gap-4.4.12.p0 is full of *CRAP*

Reported by: was Owned by: dimpase
Priority: blocker Milestone: sage-4.4.1
Component: packages: standard Keywords:
Cc: wdj Merged in: sage-4.4.1.alpha0
Authors: Dmitrii Pasechnik Reviewers: Willem Jan Palenstijn
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by was)

While gap-4.4.12.p0 was unpacking, I noticed:

gap-4.4.12.p1/src/bin/
gap-4.4.12.p1/src/bin/gap.bat
gap-4.4.12.p1/src/bin/libW11.dll
gap-4.4.12.p1/src/bin/gap.pif
gap-4.4.12.p1/src/bin/gapicon.bmp
gap-4.4.12.p1/src/bin/cygncurses-8.dll
gap-4.4.12.p1/src/bin/regtool.exe
gap-4.4.12.p1/src/bin/gaprxvt.bat
gap-4.4.12.p1/src/bin/gap.dll
gap-4.4.12.p1/src/bin/gapw95.exe
gap-4.4.12.p1/src/bin/usemem.bat
gap-4.4.12.p1/src/bin/gapp.bat
gap-4.4.12.p1/src/bin/cygpanel-8.dll
gap-4.4.12.p1/src/bin/gapw95p.exe
gap-4.4.12.p1/src/bin/rxvt.exe
gap-4.4.12.p1/src/bin/i686-pc-cygwin-gcc/
gap-4.4.12.p1/src/bin/i686-pc-cygwin-gcc/gac
gap-4.4.12.p1/src/bin/i686-pc-cygwin-gcc/gap.dll
gap-4.4.12.p1/src/bin/i686-pc-cygwin-gcc/config.h
gap-4.4.12.p1/src/bin/gapp.pif
gap-4.4.12.p1/src/bin/cygwin1.dll
gap-4.4.12.p1/src/description4r4p7
gap-4.4.12.p1/src/grp/
...

NO!!! We absolutely should not be shipping Windows frickin' binaries with Sage. Ticket #8076 introduced all these.

NOTE: It is *my* (=William's) fault that 8076 got a positive review.

Change History (10)

comment:1 Changed 10 years ago by was

  • Description modified (diff)

comment:2 Changed 10 years ago by was

wstein@boxen:/tmp$ wget ftp://ftp.gap-system.org/pub/gap/gap44/tar.bz2/gap4r4p12.tar.bz2
--16:48:48--  ftp://ftp.gap-system.org/pub/gap/gap44/tar.bz2/gap4r4p12.tar.bz2
           => `gap4r4p12.tar.bz2'
Resolving ftp.gap-system.org... 138.251.192.244
Connecting to ftp.gap-system.org|138.251.192.244|:21... connected.
Logging in as anonymous ... Logged in!
==> SYST ... done.    ==> PWD ... done.
==> TYPE I ... done.  ==> CWD /pub/gap/gap44/tar.bz2 ... done.
==> PASV ... done.    ==> RETR gap4r4p12.tar.bz2 ... done.
Length: 47,715,810 (46M) (unauthoritative)

100%[=============================================================================>] 47,715,810   207.40K/s    ETA 00:00

16:52:19 (224.11 KB/s) - `gap4r4p12.tar.bz2' saved [47715810]

wstein@boxen:/tmp$ tar jxvf gap4r4p12.tar.bz2
gap4r4/
gap4r4/etc/
gap4r4/etc/GPL
gap4r4/etc/gap_indent.vim
gap4r4/etc/xrmtcmd.c
gap4r4/etc/README.vim-utils
gap4r4/etc/emacs/
gap4r4/etc/emacs/gap-mode.doc
gap4r4/etc/emacs/gap-mode.el
gap4r4/etc/emacs/comint.el
gap4r4/etc/emacs/gap-process.el
gap4r4/etc/debug.vim
gap4r4/etc/debugvim.txt
gap4r4/etc/gap.vim
gap4r4/description4r4p7
gap4r4/bin/
gap4r4/bin/libW11.dll
gap4r4/bin/gapp.pif
gap4r4/bin/regtool.exe
gap4r4/bin/gapp.bat
gap4r4/bin/gap.dll
gap4r4/bin/i686-pc-cygwin-gcc/
gap4r4/bin/i686-pc-cygwin-gcc/gap.dll
gap4r4/bin/i686-pc-cygwin-gcc/gac
gap4r4/bin/i686-pc-cygwin-gcc/config.h
gap4r4/bin/gapw95.exe
gap4r4/bin/gapicon.bmp
gap4r4/bin/gapw95p.exe
gap4r4/bin/usemem.bat
gap4r4/bin/cygpanel-8.dll
gap4r4/bin/cygncurses-8.dll
gap4r4/bin/rxvt.exe
gap4r4/bin/gap.pif
gap4r4/bin/cygwin1.dll
gap4r4/bin/gap.bat
gap4r4/bin/gaprxvt.bat
gap4r4/grp/
...

comment:3 follow-up: Changed 10 years ago by dimpase

  • Owner changed from tbd to dimpase

I'll make a new spkg later today.

comment:4 in reply to: ↑ 3 Changed 10 years ago by dimpase

  • Status changed from new to needs_review

Replying to dimpase:

I'll make a new spkg later today.

new spkg is here: http://boxen.math.washington.edu/home/dima/packages/gap-4.4.12.p2.spkg

All I did is removing everything in src/bin/ and removing src/GAP\ 4\ PPC (apart from updating SPKG.txt etc)

Tested on Debian Linux x86_64 (just in case, as it shouldn't be anything problematic...)

comment:5 Changed 10 years ago by dimpase

  • Cc wdj added

should be very easy to review!

comment:6 Changed 10 years ago by wjp

  • Status changed from needs_review to positive_review

The package isn't perfect yet, but these changes are definitely good. Positive review.

By the way, I'm creating a p3 for ticket #8773 at the moment, starting from this p2. It will fix some strict aliasing problems with gcc 4.5.0, and will also fix the pre-applied patch to saveload.c.

comment:7 Changed 10 years ago by wjp

(The p3 mentioned in my previous comment now needs review at #8773)

comment:8 Changed 10 years ago by was

  • Merged in set to 4.4.1.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 10 years ago by mvngu

  • Authors set to Dmitrii Pasechnik
  • Reviewers set to Willem Jan Palenstijn

comment:10 Changed 10 years ago by mvngu

  • Merged in changed from 4.4.1.alpha0 to sage-4.4.1.alpha0
Note: See TracTickets for help on using tickets.