#8749 closed defect (fixed)
BSD: doctest failures on solaris (t2)
Reported by: | jhpalmieri | Owned by: | cremona |
---|---|---|---|
Priority: | blocker | Milestone: | sage-4.4.1 |
Component: | elliptic curves | Keywords: | |
Cc: | robertwb, rlm | Merged in: | sage-4.4.1.alpha3 |
Authors: | Robert Miller | Reviewers: | William Stein |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
With Sage 4.4.alpha2, I see the following:
File "/home/palmieri/t2/sage-4.4.alpha2/devel/sage-main/sage/schemes/elliptic_curves/BSD.py", line\ 304: sage: EllipticCurve('11a').prove_BSD(verbosity=2) Expected: p = 2: True by 2-descent True for p not in {2, 5} by Kolyvagin. True for p=5 by Mazur [] Got: p = 2: True by 2-descent Timeout stopped Heegner index computation... Proceeding to use heegner_index_bound instead. True for p not in {2, 5} by Kolyvagin. True for p=5 by Mazur [] ********************************************************************** File "/home/palmieri/t2/sage-4.4.alpha2/devel/sage-main/sage/schemes/elliptic_curves/BSD.py", line\ 377: sage: E.prove_BSD(verbosity=2) # long time Exception raised: Traceback (most recent call last): File "/home/palmieri/t2/sage-4.4.alpha2/local/bin/ncadoctest.py", line 1231, in run_one_test self.run_one_example(test, example, filename, compileflags) File "/home/palmieri/t2/sage-4.4.alpha2/local/bin/sagedoctest.py", line 38, in run_one_examp\ le OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags) File "/home/palmieri/t2/sage-4.4.alpha2/local/bin/ncadoctest.py", line 1172, in run_one_exam\ ple compileflags, 1) in test.globs File "<doctest __main__.example_6[22]>", line 1, in <module> E.prove_BSD(verbosity=Integer(2)) # long time###line 377: sage: E.prove_BSD(verbosity=2) # long time File "/home/palmieri/t2/sage-4.4.alpha2/local/lib/python/site-packages/sage/schemes/elliptic\ _curves/BSD.py", line 761, in prove_BSD raise RuntimeError("p = %d: ord_p_bound == %d, but sha_an.ord(p) == %d. This appears to be\ a counterexample to BSD, but is more likely a bug."%(p,ord_p_bound,BSD.sha_an.ord(p))) RuntimeError: p = 3: ord_p_bound == 1, but sha_an.ord(p) == 2. This appears to be a counterexa\ mple to BSD, but is more likely a bug. ********************************************************************** 1 items had failures: 2 of 35 in __main__.example_6 ***Test Failed*** 2 failures.
The first is a timeout issue of some sort, and perhaps could be fixed by putting in some dots ...
in case the timeout message appears. (I've also seen more failures of this type from the same file, so ellipses in several places might be needed. Test on t2 several times to see.)
I have no idea about the second issue. Presumably it's not a counterexample to BSD.
Attachments (2)
Change History (13)
comment:1 in reply to: ↑ description Changed 10 years ago by
comment:2 Changed 10 years ago by
- Cc rlm added
comment:3 Changed 10 years ago by
- Milestone changed from sage-5.0 to sage-4.4.1
Changed 10 years ago by
comment:4 Changed 10 years ago by
- Status changed from new to needs_review
comment:5 Changed 10 years ago by
- Status changed from needs_review to positive_review
comment:6 Changed 10 years ago by
- Merged in set to 4.4.1.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
comment:7 Changed 10 years ago by
- Reviewers set to William Stein
comment:8 Changed 10 years ago by
It turns out this patch works on t2, but fails on *everything* else... due to misuse of ... The attached patch fixes this by removing a newline in each ...'d test.
Changed 10 years ago by
comment:9 Changed 10 years ago by
Second patch looks good: positive review.
comment:10 Changed 10 years ago by
- Merged in changed from 4.4.1.alpha3 to sage-4.4.1.alpha3
comment:11 Changed 10 years ago by
I don't think this is fixed properly - or if it was, a very similar error is now occurring on the same doctest. See #9127
Dave
Replying to jhpalmieri:
More specifically, I just saw this on lines 304, 310, 336, and 418.