Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#8736 closed defect (fixed)

Bug in computing radical of univariate polynomial

Reported by: Johan Bosman Owned by: Alex Ghitza
Priority: minor Milestone: sage-4.4.1
Component: algebra Keywords:
Cc: Merged in: sage-4.4.1.alpha2
Authors: Johan Bosman Reviewers: Leif Leonhardy, Andrey Novoseltsev
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Johan Bosman)

From #sage-devel:

<wjp> sage: R.<x> = GF(2)[]
<wjp> sage: (x^2).radical()
<wjp> 1

Attachments (2)

trac_8736_radical_fix.patch (2.7 KB) - added by Johan Bosman 13 years ago.
trac_8736_radical_fix_single_patch.patch (1.4 KB) - added by Leif Leonhardy 13 years ago.
Johan's patch with first hunk deleted

Download all attachments as: .zip

Change History (11)

comment:1 Changed 13 years ago by Johan Bosman

Description: modified (diff)

comment:2 Changed 13 years ago by Johan Bosman

Status: newneeds_review

comment:3 Changed 13 years ago by Leif Leonhardy

I was told it is not bad to put the corresponding ticket number in the doctest and/or near the code that fixes an issue for later reference.

Changed 13 years ago by Johan Bosman

Attachment: trac_8736_radical_fix.patch added

comment:4 Changed 13 years ago by Johan Bosman

Like this? ;)

comment:5 Changed 13 years ago by Andrey Novoseltsev

Status: needs_reviewneeds_work
Work issues: patch does not apply

Probably like that, but now this patch file contains two patches and does not apply cleanly. I know that if you remove the existing patch before repeating the export command, everything should be fine and you will get a nice new patch. Maybe there are better ways which I am not aware of. Otherwise the patch seems fine to me and passes all doctests (I ran them on the previous working version).

Changed 13 years ago by Leif Leonhardy

Johan's patch with first hunk deleted

comment:6 Changed 13 years ago by Leif Leonhardy

Status: needs_workneeds_review
Work issues: patch does not apply

It's easier to just edit the patch (i.e., delete the first hunk)...

comment:7 Changed 13 years ago by Andrey Novoseltsev

Reviewers: Leif Leonhardy, Andrey Novoseltsev
Status: needs_reviewpositive_review

comment:8 Changed 13 years ago by William Stein

Merged in: 4.4.1.alpha2
Resolution: fixed
Status: positive_reviewclosed

comment:9 Changed 13 years ago by Minh Van Nguyen

Merged in: 4.4.1.alpha2sage-4.4.1.alpha2
Note: See TracTickets for help on using tickets.