Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#8735 closed defect (fixed)

Renamed size to cardinality in poset

Reported by: Florent Hivert Owned by: Florent Hivert
Priority: major Milestone: sage-4.4.1
Component: combinatorics Keywords: posets cardinality
Cc: Sage Combinat CC user Merged in: sage-4.4.1.alpha2
Authors: Florent Hivert Reviewers: Nicolas Thiery
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Nicolas M. Thiéry)

The cardinality of a set was standardized as cardinality. Posets where forgotten when standardization ocured.

Attachments (1)

trac_8735-poset_size_cardinality-fh.patch (4.3 KB) - added by Florent Hivert 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by Florent Hivert

comment:1 Changed 12 years ago by Florent Hivert

Reviewers: Nicolas Thiery
Status: newneeds_review

For the info: I got a all test passed on sage.

comment:2 Changed 12 years ago by Nicolas M. Thiéry

Description: modified (diff)
Status: needs_reviewpositive_review

Thanks for running the tests; since massena is out, I am a bit stuck on running tests ...

This change was needed, and the implementation looks right. Positive review!

Thanks for spotting and handling this!

comment:3 Changed 12 years ago by William Stein

Merged in: 4.4.1.alpha2
Resolution: fixed
Status: positive_reviewclosed

comment:4 Changed 12 years ago by Minh Van Nguyen

Merged in: 4.4.1.alpha2sage-4.4.1.alpha2

comment:5 Changed 11 years ago by Rob Beezer

See follow-up at #11214.

Note: See TracTickets for help on using tickets.