Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#8735 closed defect (fixed)

Renamed size to cardinality in poset

Reported by: hivert Owned by: hivert
Priority: major Milestone: sage-4.4.1
Component: combinatorics Keywords: posets cardinality
Cc: sage-combinat Merged in: sage-4.4.1.alpha2
Authors: Florent Hivert Reviewers: Nicolas Thiery
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by nthiery)

The cardinality of a set was standardized as cardinality. Posets where forgotten when standardization ocured.

Attachments (1)

trac_8735-poset_size_cardinality-fh.patch (4.3 KB) - added by hivert 11 years ago.

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by hivert

comment:1 Changed 11 years ago by hivert

  • Reviewers set to Nicolas Thiery
  • Status changed from new to needs_review

For the info: I got a all test passed on sage.

comment:2 Changed 11 years ago by nthiery

  • Description modified (diff)
  • Status changed from needs_review to positive_review

Thanks for running the tests; since massena is out, I am a bit stuck on running tests ...

This change was needed, and the implementation looks right. Positive review!

Thanks for spotting and handling this!

comment:3 Changed 11 years ago by was

  • Merged in set to 4.4.1.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:4 Changed 11 years ago by mvngu

  • Merged in changed from 4.4.1.alpha2 to sage-4.4.1.alpha2

comment:5 Changed 10 years ago by rbeezer

See follow-up at #11214.

Note: See TracTickets for help on using tickets.