Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#8733 closed enhancement (fixed)

documentation and stylistic clean-ups of c_graph.pyx

Reported by: mvngu Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.4.1
Component: graph theory Keywords:
Cc: Merged in: sage-4.4.1.alpha2
Authors: Minh Van Nguyen Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mvngu)

As the subject says. The goal here is to make the documentation of the module c_graph.pyx consistent and also to better document the module itself. The coding style of the whole module is inconsistent. Clean that up as well.

Attachments (1)

trac_8733-cgraph-cleanup.patch (84.5 KB) - added by mvngu 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by mvngu

  • Description modified (diff)
  • Summary changed from clean up documentation of c_graph.pyx to documentation and stylistic clean-ups of c_graph.pyx

comment:2 Changed 11 years ago by mvngu

  • Authors set to Minh Van Nguyen
  • Status changed from new to needs_review

The method degree() in the class CGraphBackend of the module c_graph.pyx has a bug in its implementation. This issue is tracked at #8395.

Changed 11 years ago by mvngu

comment:3 Changed 11 years ago by mvngu

Changes proposed by the patch include:

  • Remove trailing white spaces.
  • Don't go over 79 characters wherever possible.
  • Cross link methods and classes.
  • Add more documentation to methods.
  • Stylistic clean-ups in accordance with PEP 8.
  • Use "in" instead of "has_key()" for dictionaries.

comment:4 Changed 11 years ago by ncohen

  • Status changed from needs_review to positive_review

Well.. What can I say besides "good work" ? :-)

Definitely cleaner, still passes all tests, the documentation is clearly improved, and I was responsible for some of the mistakes you corrected (the dictionaries, for examples) :-)

Positive review, and thank you very muuuuuuuuch !


comment:5 Changed 11 years ago by mvngu

  • Reviewers set to Nathann Cohen

comment:6 Changed 11 years ago by was

  • Merged in set to 4.4.1.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 11 years ago by mvngu

  • Merged in changed from 4.4.1.alpha2 to sage-4.4.1.alpha2
Note: See TracTickets for help on using tickets.