Changes between Version 2 and Version 3 of Ticket #8703, comment 28


Ignore:
Timestamp:
02/19/13 02:12:56 (7 years ago)
Author:
darij
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #8703, comment 28

    v2 v3  
    2727- I would add "BinaryTree([])" and "BinaryTree(None)" to the examples in te docstring of the BinaryTree class. Also, in the "INPUT" section, maybe add that [] is the same as [None, None]? I must say the "INPUT" part of the docstring for BinaryTree doesn't exactly explain to me how exactly the "children" argument is getting parsed; I am used to constructors for trees being free (in the sense of, no two different inputs lead to the same tree), so I wouldn't say this is very intuitive. It's "explained" in the __init__ sourcecode, but that's uncommented and I have no idea what it does :(
    2828
    29 Might also want to point out that these binary trees are what many people call planar trees (even if it's a bad name), i. e., the order of the children on each node matters.
     29Might also want to point out that these binary trees are planar aka what you call ordered, i. e., the order of the children on each node matters.
    3030
    3131- In the "show" method of BinaryTree, can the tree_orientation be passed as a keyword? I know a lot of people who don't draw trees upside down...