Opened 7 years ago

Closed 2 years ago

#8678 closed enhancement (fixed)

Improvements for morphisms of ModulesWithBasis

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-6.4
Component: categories Keywords: homsets, module morphisms, days64
Cc: sage-combinat Merged in:
Authors: Nicolas M. Thiéry Reviewers: Franco Saliola
Report Upstream: N/A Work issues:
Branch: 71b36da (Commits) Commit: 71b36dad34c98b32ecffb197633895a66d38550f
Dependencies: #10668, #17160 Stopgaps:

Description (last modified by nthiery)

This ticket implements:

  • inverses for morphisms of finite dimensional vector spaces
  • tensor products of morphisms

and improves:

  • triangular morphisms over base rings

Declares CombinatorialFreeModule? indexed by a finite set as being finite dimensional.

Change History (78)

comment:1 Changed 7 years ago by nthiery

  • Description modified (diff)
  • Keywords homsets module morphisms added; homsest removed
  • Milestone set to sage-5.0
  • Status changed from new to needs_work

comment:2 Changed 4 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:3 follow-up: Changed 4 years ago by saraedum

This is is a very old ticket. Anyway, can I find the patch that fixes _test_category somewhere? This also fails for #15154. Or should I just disable these tests?

comment:4 in reply to: ↑ 3 Changed 4 years ago by saraedum

Replying to saraedum:

This is is a very old ticket. Anyway, can I find the patch that fixes _test_category somewhere? This also fails for #15154. Or should I just disable these tests?

Since there is no reply here, I created a partial fix at #15232.

comment:5 Changed 4 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 3 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:7 Changed 3 years ago by nthiery

  • Branch set to u/nthiery/categories/module-morphisms-8678

comment:8 Changed 3 years ago by git

  • Commit set to 47e0eb92f3d19d74c98af37c473aa33b08e15527

Branch pushed to git repo; I updated commit sha1. New commits:

47e0eb98678: Imported stuff relevant to morphisms from trac_11111-finite_dimensional_modules-nt.patch

comment:9 Changed 3 years ago by git

  • Commit changed from 47e0eb92f3d19d74c98af37c473aa33b08e15527 to 553c5ded43809f26579269847dbfe0c351cdc0fa

Branch pushed to git repo; I updated commit sha1. New commits:

553c5de8678: Imported module_morphism_function_extend-fh.patch

comment:10 Changed 3 years ago by nthiery

  • Dependencies set to 10668

comment:11 Changed 3 years ago by nthiery

  • Dependencies changed from 10668 to #10668
  • Description modified (diff)

comment:12 Changed 3 years ago by git

  • Commit changed from 553c5ded43809f26579269847dbfe0c351cdc0fa to 815b8269419a036f5274ecfc0a45e51f92cd7a5c

Branch pushed to git repo; I updated commit sha1. New commits:

15cd16f8678: a CombinatorialFreeModule is FiniteDimensional as soon as the index set is in Sets().Finite()
815b8268678: add support for the matrix of a matrix on the right + improvements to the documentation

comment:13 Changed 3 years ago by git

  • Commit changed from 815b8269419a036f5274ecfc0a45e51f92cd7a5c to 21bb24cb3f04031e14fb1227fce8350089cec176

Branch pushed to git repo; I updated commit sha1. New commits:

ac38eda10668: trivial ReST fix
dc5fc3dMerge branch 'categories/morphism-methods-10668' into categories/module-morphisms-8678
21bb24c8678: fixed doctests: (triangular) module morphisms now inherit properly from categories

comment:14 Changed 3 years ago by git

  • Commit changed from 21bb24cb3f04031e14fb1227fce8350089cec176 to 0b1810ba24a7316b362f88cd176cbb12e280db2b

Branch pushed to git repo; I updated commit sha1. New commits:

eaa56bc16340: super_structure_categories -> all_structure_super_categories
afc9724Merge branch 'develop' into categories/full-subcategories-16340
21bf60aMerge branch 'categories/full-subcategories-16340' and '6.3beta5' into categories/morphism-methods-10668
442161eMerge branch 'categories/morphism-methods-10668' and '6.3 beta5' into categories/module-morphisms-8678
838bb3f10668: super_structure_categories -> all_structure_super_categories
9de890910668: super_structure_categories -> all_structure_super_categories
0b1810bMerge branch 'categories/morphism-methods-10668' into categories/module-morphisms-8678

comment:15 Changed 3 years ago by git

  • Commit changed from 0b1810ba24a7316b362f88cd176cbb12e280db2b to b62ebe92395be14f954a6e12d0dae506f257d5a1

Branch pushed to git repo; I updated commit sha1. New commits:

b62ebe98678: trivial ReST fix

comment:16 Changed 3 years ago by git

  • Commit changed from b62ebe92395be14f954a6e12d0dae506f257d5a1 to 8b971f47618b96da1276f2c550d707e424628af1

Branch pushed to git repo; I updated commit sha1. New commits:

8b971f48678: bug fix and doctests for CombinatorialFreeModule being automatically finite dimensional

comment:17 Changed 3 years ago by git

  • Commit changed from 8b971f47618b96da1276f2c550d707e424628af1 to 494da7434395e82e1fffe07d44698eab3c74b3be

Branch pushed to git repo; I updated commit sha1. New commits:

494da748678: trivial ReST fix

comment:18 Changed 3 years ago by git

  • Commit changed from 494da7434395e82e1fffe07d44698eab3c74b3be to cb5a236c1e7a4a0f590f197d2769756a75456bcd

Branch pushed to git repo; I updated commit sha1. New commits:

cb5a2368678: trivial doctests fix (more categories are finite dimensional now)

comment:19 Changed 3 years ago by git

  • Commit changed from cb5a236c1e7a4a0f590f197d2769756a75456bcd to aa7fe1df3be82feb1154d27761912fc179653224

Branch pushed to git repo; I updated commit sha1. New commits:

aa7fe1d8678: noted known pickling issue

comment:20 Changed 3 years ago by nthiery

  • Description modified (diff)
  • Work issues set to failing test with steenrod and quiver algebras

Now mosts tests pass. The remaining failing ones are because of some finite dimensional algebras over a finite field become finite, hence finite semigroups. And currently finite semigroups are automatically made into enumerated sets using their generators; however those generators are not always available.

comment:21 Changed 3 years ago by git

  • Commit changed from aa7fe1df3be82feb1154d27761912fc179653224 to 445c925e3f958e4252ba62a6177de4b4d6a86367

Branch pushed to git repo; I updated commit sha1. New commits:

445c9258768: Fixed doctests

comment:22 Changed 3 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:23 Changed 3 years ago by git

  • Commit changed from 445c925e3f958e4252ba62a6177de4b4d6a86367 to 8054997140d50285a05a326ca3d7850421fb7036

Branch pushed to git repo; I updated commit sha1. New commits:

93273a7Merge branch 'u/nthiery/categories/full-subcategories-16340' of trac.sagemath.org:sage into public/categories/full_subcategories-16340
edb29e6Fixed trivial doctest failures.
99a8eb1Merge branch 'public/categories/full_subcategories-16340' of trac.sagemath.org:sage into categories/full-subcategories-16340
8bc456cMerge branch 'master=6.3' into categories/full-subcategories-16340
56e982eMerge branch 'categories/full-subcategories-16340' and 6.3 into categories/morphism-methods-10668
016cd16#16340: Revert ReST typo fix in ell_curve_isogeny.py to avoid conflict with other ticket handling it
d147678Merge branch 'develop=6.4.beta0' into categories/morphism-methods-10668
8054997Merge branch 'categories/morphism-methods-10668' into categories/module-morphisms-8678

comment:24 Changed 3 years ago by git

  • Commit changed from 8054997140d50285a05a326ca3d7850421fb7036 to 314ee443ef1818c577439c9dec3709c02ea3f303

Branch pushed to git repo; I updated commit sha1. New commits:

16acc6c8678: complete proofreading
a2a16148678: removed explicit doctest:xxx: source line number from a doctest
737a8f016340: improved warnings about the current limitation of the model
282ac4e16340: fixed typos reported by Darij
1e4418fMerge branch 'develop' into categories/full-subcategories-16340
314ee44Merge branch 'categories/full-subcategories-16340' into categories/module-morphisms-8678

comment:25 Changed 3 years ago by git

  • Commit changed from 314ee443ef1818c577439c9dec3709c02ea3f303 to 69070248220d3849e65051f2bc2404e915988dce

Branch pushed to git repo; I updated commit sha1. New commits:

69070248678: trivial doctest update after merge with develop

comment:26 Changed 3 years ago by git

  • Commit changed from 69070248220d3849e65051f2bc2404e915988dce to 6136990f440f23316222947a40df4659ddb12c3a

Branch pushed to git repo; I updated commit sha1. New commits:

98521738678: rewrote a few tests introduced by #16296 so that they do not depend on the number of axioms defined in Sage
6136990See discussion on: https://groups.google.com/d/msg/sage-devel/IT_gI_cx0co/QhxdAZeaJzMJ for details.

comment:27 Changed 3 years ago by tscrim

From the diff, you've accidentally removed the i += 1, so it should run forever (provided the 0th component is non-trivial). Ah what I wouldn't give for a python builtin do-while loop...

comment:28 Changed 3 years ago by git

  • Commit changed from 6136990f440f23316222947a40df4659ddb12c3a to ce2a56bf5bbedafe501f1207ff3a5c80aa6f4453

Branch pushed to git repo; I updated commit sha1. New commits:

ce2a56b8678: oops, restored accidently deleted increment

comment:29 Changed 3 years ago by virmaux

  • Branch changed from u/nthiery/categories/module-morphisms-8678 to u/virmaux/categories/module-morphisms-8678

comment:30 Changed 3 years ago by virmaux

  • Commit changed from ce2a56bf5bbedafe501f1207ff3a5c80aa6f4453 to 0b4b010c1b0558e43726657f2a5e53ef38031b8c

Humph, so two points:

1- The last push correct a bug in TriangularModuleMorphism? with on_basis.

2- I did not know that my push would have change the branch (but I should as it is a 'private' one) and do not know how to replace back the right branch, which is u/nthiery/categories/module-morphisms-8678. Sorry for the noise :s

At least, if my correction is wrong it should be very easy to reset :)


New commits:

0b4b010#8678: fixed on_basis in TriangularModuleMoprhism

comment:31 Changed 3 years ago by nthiery

  • Branch changed from u/virmaux/categories/module-morphisms-8678 to u/nthiery/categories/module-morphisms-8678

comment:32 Changed 3 years ago by git

  • Commit changed from 0b4b010c1b0558e43726657f2a5e53ef38031b8c to 9bb4b48b9d311f4e85b7702355a4ee92d038d857

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

d8a8373Fixing some typos
75615b510668: trivial doctest updates
d5d3a9710668: improved description of the HomsetsOf class
5416ba0Add a note on the MRO used for Homset._abstract_element_class
23639a9Fix more typos
02a6a8a10668: fixed representation of the category of endsets
477d38110668: Homsets.Endset.super_category -> extra_super_category + documentation
877bfdb10668: fix: Modules.EndCategory -> Modules.Homsets.Endset + made it functional: endsets of modules are algebras
f86824e10668: documentation for HomsetsCategory.category_of + fixed typo in doctest nearby
9bb4b488678: merge in #10668, including develop=6.4 beta4

comment:33 Changed 3 years ago by SimonKing

  • Cc SimonKing added

Last 10 new commits:

d8a8373Fixing some typos
75615b510668: trivial doctest updates
d5d3a9710668: improved description of the HomsetsOf class
5416ba0Add a note on the MRO used for Homset._abstract_element_class
23639a9Fix more typos
02a6a8a10668: fixed representation of the category of endsets
477d38110668: Homsets.Endset.super_category -> extra_super_category + documentation
877bfdb10668: fix: Modules.EndCategory -> Modules.Homsets.Endset + made it functional: endsets of modules are algebras
f86824e10668: documentation for HomsetsCategory.category_of + fixed typo in doctest nearby
9bb4b488678: merge in #10668, including develop=6.4 beta4

comment:34 Changed 3 years ago by nthiery

  • Cc SimonKing removed
  • Dependencies changed from #10668 to #10668, #17160

#17160 I am working on now should fix the failing tests.

comment:35 Changed 3 years ago by git

  • Commit changed from 9bb4b48b9d311f4e85b7702355a4ee92d038d857 to 6f22b7284e4b218bd7e1494d2f140d3d816139e8

Branch pushed to git repo; I updated commit sha1. New commits:

9c939ae16340: Merge branch 'develop=6.4 beta6' into categories/full-subcategories-16340
5f9668617160: Merge branch 'categories/morphism-methods-10668'
f027ce217610: first draft of finitely generated axiom for magmas/groups/axioms
dabcafdMerge branch 'develop' into t/17160/categories/finitely-generated-magmas-17160
6f22b72Merge branch 't/17160/categories/finitely-generated-magmas-17160' into t/8678/categories/module-morphisms-8678

comment:36 Changed 3 years ago by git

  • Commit changed from 6f22b7284e4b218bd7e1494d2f140d3d816139e8 to 830c550986d65141517ed630fc94b22e126a89f6

Branch pushed to git repo; I updated commit sha1. New commits:

830c5508678: fixed missing import

comment:37 Changed 3 years ago by git

  • Commit changed from 830c550986d65141517ed630fc94b22e126a89f6 to 0e89bb7b62f9a215c14dfd0fd8c266bd20abeb84

Branch pushed to git repo; I updated commit sha1. New commits:

0e89bb7Fixed ReST typo

comment:38 Changed 3 years ago by git

  • Commit changed from 0e89bb7b62f9a215c14dfd0fd8c266bd20abeb84 to a117dc5afbd41b634df055ee1f75101ee1e75fe5

Branch pushed to git repo; I updated commit sha1. New commits:

a117dc58678: co_reduced -> coreduced + added check (valid only for a field or unitriangular + doc improvements here and there

comment:39 Changed 3 years ago by git

  • Commit changed from a117dc5afbd41b634df055ee1f75101ee1e75fe5 to b2b10fcb8253b5cf0966d636aa4b5a51ce5fa5ee

Branch pushed to git repo; I updated commit sha1. New commits:

b2b10fc8678: unitriangular=lower as shorthand for triangular=lower, unitriangular=True; added sanity checks and tests for cokernel_basis_indices

comment:40 Changed 3 years ago by git

  • Commit changed from b2b10fcb8253b5cf0966d636aa4b5a51ce5fa5ee to 05634b4137ec056ff87f4b4db12b7824a181dc06

Branch pushed to git repo; I updated commit sha1. New commits:

93908388678: moved ModuleMorphism's code from sage.categories.modules_with_basis to sage.modules.module_with_basis_morphism
05634b48678: Follow up on the previous commit: updating paths + extracted new abstract class ModuleMorphism

comment:41 Changed 3 years ago by git

  • Commit changed from 05634b4137ec056ff87f4b4db12b7824a181dc06 to fa9e2a6697a85dc41022c859f7036a597f2c5619

Branch pushed to git repo; I updated commit sha1. New commits:

fa9e2a68678: Added ModuleMorphismFromMatrix class + better API for constructing them through module_morphism(matrix=...)

comment:42 Changed 3 years ago by git

  • Commit changed from fa9e2a6697a85dc41022c859f7036a597f2c5619 to 5409f2fea9db12e642b803003af6f6e662beb385

Branch pushed to git repo; I updated commit sha1. New commits:

5409f2f8678: More doc and small fixes for previous commit

comment:43 Changed 3 years ago by git

  • Commit changed from 5409f2fea9db12e642b803003af6f6e662beb385 to 87cd8cad4a464c8b1a7926597b390517cb880c20

Branch pushed to git repo; I updated commit sha1. New commits:

87cd8ca8678: Added comment about element class creation for module morphisms

comment:44 Changed 3 years ago by git

  • Commit changed from 87cd8cad4a464c8b1a7926597b390517cb880c20 to 42d98618c28d43f02b39effb0051beb8e5b01550

Branch pushed to git repo; I updated commit sha1. New commits:

42d98618678: Small Rest fixes to let the doc compile

comment:45 Changed 3 years ago by git

  • Commit changed from 42d98618c28d43f02b39effb0051beb8e5b01550 to 2f0c203d7d048650f1ece08322225586e82e33be

Branch pushed to git repo; I updated commit sha1. New commits:

2f0c203#8678: trivial doctest update (group algebras of finite groups are finite dimensional)

comment:46 Changed 3 years ago by git

  • Commit changed from 2f0c203d7d048650f1ece08322225586e82e33be to 078b562a2f68695ac47203687b1f52051575f8be

Branch pushed to git repo; I updated commit sha1. New commits:

078b562#8678: trivial doctest update (group algebras of finite groups are finite dimensional)

comment:47 Changed 3 years ago by git

  • Commit changed from 078b562a2f68695ac47203687b1f52051575f8be to eaded9722b24c13b06aa55bc8711f043fbaf4670

Branch pushed to git repo; I updated commit sha1. New commits:

d9482818678: implemented (triangular) module morphisms from a function; more doc and tests needed
eaded978678: systematic doc and tests for the various ModuleMorphism classes + minor fixes (e.g. on_basis)

comment:48 Changed 3 years ago by git

  • Commit changed from eaded9722b24c13b06aa55bc8711f043fbaf4670 to 4125b2a6394cbf3f594991513394fa5958ae841b

Branch pushed to git repo; I updated commit sha1. New commits:

4125b2a8678: more doc improvements

comment:49 Changed 3 years ago by nthiery

  • Status changed from needs_work to needs_review

comment:50 Changed 3 years ago by nthiery

Hi Franco,

I believe I have taken care of everything we discussed on Monday. So back to needs review! There remains to little points to be discussed in Davis:

  • Should the user documentation about triangular morphisms be in the class or in module_morphism?
  • triangular=True led to triangular="lower" while the default value for triangular is "upper"

Cheers from warm Davis!

Nicolas

comment:51 Changed 3 years ago by git

  • Commit changed from 4125b2a6394cbf3f594991513394fa5958ae841b to 1a4e89745eb6284406b149a478ea6558a6e7d875

Branch pushed to git repo; I updated commit sha1. New commits:

1a4e8978678: Added abstract methods Sets.MorphismMethods.__invert__

comment:52 Changed 3 years ago by git

  • Commit changed from 1a4e89745eb6284406b149a478ea6558a6e7d875 to f9b1f877d5e481a916ddf62e8c4be1f1e0af9e4d

Branch pushed to git repo; I updated commit sha1. New commits:

f9b1f878678: fixed bug introduced recently about the initialization of TriangularModuleMorphism._invertible

comment:53 Changed 3 years ago by git

  • Commit changed from f9b1f877d5e481a916ddf62e8c4be1f1e0af9e4d to 1f9981f65d1cd59d6556239acb0749a471fba0e9

Branch pushed to git repo; I updated commit sha1. New commits:

cf9b429Fixed ReST typo
aff268917160: fixed category for finite set endomaps + minor __init__ refactoring
1f9981fMerge branch 'categories/finitely-generated-magmas-17160' into categories/module-morphisms-8678

comment:54 Changed 3 years ago by darij

Needs review, but depends on a blue ticket, and work issues listed?

comment:55 Changed 3 years ago by nthiery

Just a tip: given the many modifications here and there, and the new classes, it's might be simpler to review directly the whole new file src/sage/modules/module_with_basis_morphism.py rather than looking at its diff. Otherwise, I took care of the moving of the code from modules_with_basis.py in a separate commit, so that you can diff from there.

comment:56 Changed 3 years ago by nthiery

  • Work issues failing test with steenrod and quiver algebras deleted

I had forgotten to clear the issue. #17160 is just waiting for feedback on the sage mailing list to be finalized. In any cases both tickets are rather independent, so the review of the code of this one can start right away. Of course it will be necessary to rerun the tests once the failures coming from #17160 will be fixed

comment:57 Changed 3 years ago by git

  • Commit changed from 1f9981f65d1cd59d6556239acb0749a471fba0e9 to 7861e3252141d84fcd369194e1e22459a9ffc406

Branch pushed to git repo; I updated commit sha1. New commits:

34ee60d8678: improved support for pickling and default value of the invertible option
24ed5278678: specify explicitly that one morphism in sage.algebras.hall_algebra is invertible to make up for the change in 4125b2a6394cbf3f594991513394fa5958ae841b
7861e328678: ReST fix

comment:58 Changed 3 years ago by git

  • Commit changed from 7861e3252141d84fcd369194e1e22459a9ffc406 to 6de563d78fb35a84959f3dfa506329519c5ce962

Branch pushed to git repo; I updated commit sha1. New commits:

4b3d74cMerge branch 'develop' into categories/finitely-generated-magmas-17160
6de563dMerge branch 'categories/finitely-generated-magmas-17160 + develop=6.6beta5' into categories/module-morphisms-8678

comment:59 Changed 3 years ago by saliola

  • Branch changed from u/nthiery/categories/module-morphisms-8678 to u/saliola/categories/module-morphisms-8678

comment:60 follow-up: Changed 3 years ago by saliola

  • Commit changed from 6de563d78fb35a84959f3dfa506329519c5ce962 to 0d3af4d384a8c756ae59c50023aa5972fcd5b969
  • Keywords days64 added
  • Reviewers set to Franco Saliola
  • Status changed from needs_review to needs_info

Here is my review. I pushed some typo fixes, improved some of the documentation and added a few doctests. Here are a few issues and questions:

  • I don't understand the comment in src/sage/categories/finitely_generated_semigroups.py:
    # TODO: update transitive ideal
    
  • a couple of doctests include the following line:
    sage: import __main__; __main__.f = f  
    

can you explain why this is necessary?

  • line 1015 of src/sage/modules/module_with_basis_morphism.py: the doc says this should work over an ring, so perhaps the following is not a valid assumption?
    c = c / s[j]  # the base ring is a field
    
  • the doctests don't pass, but this seems to be related to #17160

New commits:

0d3af4d8678: typo fixes and some new doctests

comment:61 Changed 3 years ago by nthiery

  • Branch changed from u/saliola/categories/module-morphisms-8678 to u/nthiery/categories/module-morphisms-8678

comment:62 Changed 3 years ago by git

  • Commit changed from 0d3af4d384a8c756ae59c50023aa5972fcd5b969 to a2ee49bb964a25e8f398f7681a74780ba65c2542

Branch pushed to git repo; I updated commit sha1. New commits:

a2ee49b8678: deprecated triangular=True; added more sanity checks; spacing improvements

comment:63 Changed 3 years ago by git

  • Commit changed from a2ee49bb964a25e8f398f7681a74780ba65c2542 to a2f158c1ae29a9ff70e295e1dc028d1718fd09ac

Branch pushed to git repo; I updated commit sha1. New commits:

d2e836a8678: module_with_basis_morphism.py -> modules_with_basis/morphism.py
a2f158c8678: module_with_basis_morphism.py -> modules_with_basis/morphism.py

comment:64 in reply to: ↑ 60 Changed 3 years ago by nthiery

Hi Franco!

Replying to saliola:

Here is my review. I pushed some typo fixes, improved some of the documentation and added a few doctests.

Thanks! I double checked your changes and am happy with them. This prompted a second pass of little things here and there to make the doc more uniform. I also implemented the two we had discussed.

Here are a few issues and questions:

  • I don't understand the comment in src/sage/categories/finitely_generated_semigroups.py:
    # TODO: update transitive ideal
    

The code uses TransitiveIdeal? which is being deprecated in favor of RecursivelyEnumeratedSet?. I have added this as comment on #17160.

  • a couple of doctests include the following line:
    sage: import __main__; __main__.f = f  
    

can you explain why this is necessary?

A function defined interactively is not picklable, which prevents us from using it to test the pickling of objects built upon them. This classical trick fakes f being defined in a Python module.

  • line 1015 of src/sage/modules/module_with_basis_morphism.py: the doc says this should work over an ring, so perhaps the following is not a valid assumption?
    c = c / s[j]  # the base ring is a field
    

The documentation mentions:

        - ``self`` -- a triangular morphism over a field, or a
          unitriangular morphism over a ring

which is tested a couple lines above:

        if G.base_ring() not in Fields and not self._unitriangular:
            raise NotImplementedError, "coreduce for a triangular but not unitriangular morphism over a ring"
  • the doctests don't pass, but this seems to be related to #17160

Yup. Next step is to cleanup #17160. And then we will know better if there are a couple trivial doctests that need to be updated here.

Cheers,

Nicolas

comment:65 Changed 3 years ago by saliola

The latest branch causes some problems:

> git trac pull
> sage -br
**********************************************************************

Oops, Sage crashed. We do our best to make it stable, but...

The error message in the crash report is:

ImportError: No module named modules_with_basis.morphism

comment:66 Changed 3 years ago by saliola

I wanted to make the following change:

+            sage: ult = lambda i: sum(  y[j] for j in range(i,4)  ) # uni-upper
+            sage: phi = X.module_morphism(ult, triangular="lower", codomain=Y)

The comment # uni-upper should be uni-lower.

comment:67 Changed 3 years ago by git

  • Commit changed from a2f158c1ae29a9ff70e295e1dc028d1718fd09ac to d9b550784cba2660a94c50f4835a952138f4b103

Branch pushed to git repo; I updated commit sha1. New commits:

d9b55078678: fixed missing __init__.py

comment:68 Changed 3 years ago by git

  • Commit changed from d9b550784cba2660a94c50f4835a952138f4b103 to 5eca4c141a24f5afbd4df35a2f7b8bc2efa88939

Branch pushed to git repo; I updated commit sha1. New commits:

5eca4c18678: doc: fixed misleading 'tolower' comment + micro phrasing improvement

comment:69 Changed 3 years ago by saliola

Hello Nicolas. Thanks for the answers and the fixes. This looks good to me now. I'm ready to set this to positive review once #17160 is finalized (i.e., once all doctests here pass).

comment:70 Changed 3 years ago by git

  • Commit changed from 5eca4c141a24f5afbd4df35a2f7b8bc2efa88939 to 853a04ef4744952b2effa54646ee7b8827b499cf

Branch pushed to git repo; I updated commit sha1. New commits:

853a04e8678: sage.modules.modules_with_basis -> sage.modules.with_basis + directory doc + added doc to the ref manual

comment:71 Changed 3 years ago by git

  • Commit changed from 853a04ef4744952b2effa54646ee7b8827b499cf to 7b6e49555a6c3d954fb7929d3b1254244c7fef2c

Branch pushed to git repo; I updated commit sha1. New commits:

ad5d6c08678: permutation groups are finitely generated, finite fields are enumerated, fixes
839200e8678: More doctest updates. Should almost pass all tests.
919a215Merge branch 'develop = sage 6.6 beta6' into categories/finitely-generated-magmas-17160
7b6e495Merge branch 'categories/finitely-generated-magmas-17160 + develop=6.6beta6' into categories/module-morphisms-8678

comment:72 Changed 3 years ago by git

  • Commit changed from 7b6e49555a6c3d954fb7929d3b1254244c7fef2c to b4b28b9cf405c9b16c769d6576a1f3110a818bce

Branch pushed to git repo; I updated commit sha1. New commits:

b4b28b98678: Trivial doctest update

comment:73 Changed 3 years ago by saliola

I've looked over all the recent changes, too. Positive review, once all doctests pass (which they appear to do here).

comment:74 Changed 3 years ago by git

  • Commit changed from b4b28b9cf405c9b16c769d6576a1f3110a818bce to 71b36dad34c98b32ecffb197633895a66d38550f

Branch pushed to git repo; I updated commit sha1. New commits:

5e6c707Do not build the Jinja2 docs
71b36daMerge branch 't/18012/sphinx_depends_on_jinja2' into categories/module-morphisms-8678

comment:75 Changed 3 years ago by tscrim

FYI - #17160 is finalized.

comment:76 Changed 3 years ago by nthiery

  • Status changed from needs_info to positive_review

On {{{Linux sagange 3.2.0-4-amd64 #1 SMP Debian 3.2.63-2+deb7u1 x86_64 GNU/Linux}}}, and after merging in 6.6.rc0, I am getting only those errors with make ptestlong:

sage -t --long src/sage/doctest/control.py  # 1 doctest failed
sage -t --long src/sage/calculus/calculus.py  # 1 doctest failed
sage -t --long src/sage/misc/trace.py  # 2 doctests failed
sage -t --long src/sage/modular/arithgroup/arithgroup_perm.py  # Timed out
sage -t --long src/sage/homology/simplicial_complex.py  # 1 doctest failed

Sounds like they are all maxima related, and I doubt there is any relation to this ticket; rc0 fails similarly. Hence I am setting this to positive review on behalf of Franco.

comment:77 Changed 3 years ago by nthiery

  • Type changed from defect to enhancement

comment:78 Changed 2 years ago by vbraun

  • Branch changed from u/nthiery/categories/module-morphisms-8678 to 71b36dad34c98b32ecffb197633895a66d38550f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.