Opened 10 years ago

Closed 9 years ago

#8658 closed defect (fixed)

opencdk spkg has incorrect DSO linking

Reported by: vbraun Owned by: AlexGhitza
Priority: major Milestone: sage-4.4.4
Component: algebra Keywords: DSO
Cc: Merged in: sage-4.4.4.alpha1
Authors: Volker Braun Reviewers: Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

opencdk fails to explicitly link against libgcrypt. This is exposed by the changed ld behavior in Fedora 13 (beta), see https://fedoraproject.org/wiki/UnderstandingDSOLinkChange

The new version fixes this and is necessary to compile on F13. You can get it at

http://www.stp.dias.ie/~vbraun/Sage/spkg/opencdk-0.6.6.p4.spkg

Change History (4)

comment:1 Changed 9 years ago by mhansen

  • Authors changed from vbraun to Volker Braun
  • Reviewers set to Mike Hansen
  • Status changed from new to needs_work

I'd like to get this in 4.4.4. There are a couple of issues. /bin/sh on boxen doesn't like Makefile.{am,in} . Also, sed on Solaris doesn't support -i. While the Makefiles don't need to be used on Solaris, it be nice to not have those fail. Also, we should check the exit status to make sure the command successfully ran.

comment:2 Changed 9 years ago by vbraun

  • Status changed from needs_work to needs_review

Ok updated version now copies a suitable Makefile.in file from patches/ instead of the sed hack:

http://www.stp.dias.ie/~vbraun/Sage/spkg/opencdk-0.6.6.p4.spkg

The Makefile.am is not needed, so I did not change it. Hopefully upstream will make a new release before we have to edit this again. The Fedora people are trying to push these changes upstream.

comment:3 Changed 9 years ago by mhansen

  • Status changed from needs_review to positive_review

comment:4 Changed 9 years ago by mhansen

  • Merged in set to sage-4.4.4.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.