Opened 11 years ago
Last modified 6 years ago
#8617 needs_work enhancement
Add galrep by Drew Sutherland to Sage
Reported by: | was | Owned by: | davidloeffler |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | number fields | Keywords: | |
Cc: | Merged in: | ||
Authors: | William Stein, Drew Sutherland | Reviewers: | Robert Miller |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
The two data files go in SAGE_ROOT/data/extcode/galrep
Attachments (5)
Change History (23)
Changed 11 years ago by
Changed 11 years ago by
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
Changed 11 years ago by
comment:3 Changed 11 years ago by
- Status changed from needs_review to needs_work
I will review this ticket, as long as someone else makes the necessary changes to the extcode spkg to include the galrep_*.dat
files in the appropriate manner.
comment:4 Changed 11 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
Changed 11 years ago by
comment:5 Changed 11 years ago by
PS - I don't think this is quite the right way to update extcode... I didn't realize I had done 'alpha0' --> 'alpha1'. I suppose the release manager would just add the "galrep" directory to the data/extcode directory, which would then be included in the new extcode spkg automatically by the dist script (Is this correct?)
comment:6 Changed 11 years ago by
- Reviewers set to Robert Miller
- Status changed from needs_review to positive_review
Since I'm doing release management for sage-4.5, I can just merge the files here the right way, and since I haven't actually contributed anything, I feel as if I can give it a positive review as is.
comment:7 Changed 11 years ago by
- Description modified (diff)
comment:8 Changed 11 years ago by
- Description modified (diff)
comment:9 Changed 11 years ago by
- Merged in set to sage-4.5.alpha4
- Resolution set to fixed
- Status changed from positive_review to closed
comment:10 Changed 11 years ago by
comment:11 Changed 11 years ago by
- Resolution fixed deleted
- Status changed from closed to new
Removed $SAGE_ROOT/data/extcode/galrep
, as well as the relevant lines from module_list.py
, sage/libs/all.py
, setup.py
and deleted sage/libs/galrep
.
:-(
comment:12 Changed 11 years ago by
- Status changed from new to needs_work
comment:13 Changed 11 years ago by
- Merged in sage-4.5.alpha4 deleted
comment:14 Changed 10 years ago by
Note - I plan to include this in PSAGE: http://code.google.com/p/purplesage/issues/detail?id=10
comment:15 Changed 7 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:16 Changed 7 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:17 Changed 7 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:18 Changed 6 years ago by
- Milestone changed from sage-6.3 to sage-6.4
This looks malformed -- there is no galrep.c code included in the patch (that I can see).