Context Navigation

← Previous Ticket
Next Ticket →

#8617 needs_work enhancement

Add galrep by Drew Sutherland to Sage

Reported by:	was	Owned by:	davidloeffler
Priority:	major	Milestone:	sage-6.4
Component:	number fields	Keywords:
Cc:		Merged in:
Authors:	William Stein, Drew Sutherland	Reviewers:	Robert Miller
Report Upstream:	N/A	Work issues:
Branch:		Commit:
Dependencies:		Stopgaps:

Description (last modified by rlm)

The two data files go in SAGE_ROOT/data/extcode/galrep

Attachments (5)

trac_8617.patch (15.3 KB) - added by was 11 years ago.
galrep_ecdata.dat (2.0 MB) - added by was 11 years ago.
galrep_gl2data.dat (779.5 KB) - added by was 11 years ago.
trac_8617-part2.patch (28.2 KB) - added by was 11 years ago.
trac_8617-part3.patch (1.5 KB) - added by rlm 11 years ago.

Change History (23)

Changed 11 years ago by was

Attachment trac_8617.patch added

Changed 11 years ago by was

Attachment galrep_ecdata.dat added

Changed 11 years ago by was

Attachment galrep_gl2data.dat added

comment:1 Changed 11 years ago by was

Description modified (diff)
Status changed from new to needs_review

comment:2 Changed 11 years ago by ncalexan

This looks malformed -- there is no galrep.c code included in the patch (that I can see).

Changed 11 years ago by was

Attachment trac_8617-part2.patch added

comment:3 Changed 11 years ago by rlm

Authors set to William Stein, Drew Sutherland
Status changed from needs_review to needs_work

I will review this ticket, as long as someone else makes the necessary changes to the extcode spkg to include the galrep_*.dat files in the appropriate manner.

comment:4 Changed 11 years ago by rlm

Authors changed from William Stein, Drew Sutherland to William Stein, Drew Sutherland, Robert Miller
Description modified (diff)
Status changed from needs_work to needs_review

Changed 11 years ago by rlm

Attachment trac_8617-part3.patch added

comment:5 Changed 11 years ago by rlm

PS - I don't think this is quite the right way to update extcode... I didn't realize I had done 'alpha0' --> 'alpha1'. I suppose the release manager would just add the "galrep" directory to the data/extcode directory, which would then be included in the new extcode spkg automatically by the dist script (Is this correct?)

comment:6 Changed 11 years ago by rlm

Authors changed from William Stein, Drew Sutherland, Robert Miller to William Stein, Drew Sutherland
Reviewers set to Robert Miller
Status changed from needs_review to positive_review

Since I'm doing release management for sage-4.5, I can just merge the files here the right way, and since I haven't actually contributed anything, I feel as if I can give it a positive review as is.

comment:7 Changed 11 years ago by rlm

Description modified (diff)

comment:8 Changed 11 years ago by rlm

Description modified (diff)

comment:9 Changed 11 years ago by rlm

Merged in set to sage-4.5.alpha4
Resolution set to fixed
Status changed from positive_review to closed

comment:10 Changed 11 years ago by rlm

I'm reverting this ticket, as it causes several weird problems: see #9445 and #9490.

comment:11 Changed 11 years ago by rlm

Resolution fixed deleted
Status changed from closed to new

Removed $SAGE_ROOT/data/extcode/galrep, as well as the relevant lines from module_list.py, sage/libs/all.py, setup.py and deleted sage/libs/galrep.

:-(