Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#8565 closed defect (fixed)

atan2(-pi,0) throws "divide by zero"

Reported by: burcin Owned by: burcin
Priority: major Milestone: sage-4.4.1
Component: symbolics Keywords: pynac
Cc: Merged in: sage-4.4.1.alpha2
Authors: Burcin Erocal, Richard Kreckel, Jens Vollinga Reviewers: Robert Mařík
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

From sage-devel: 

the summary is:
-------------------
atan2(3,0)   --> 1/2*pi
atan2(-3,0)  --> -1/2*pi
atan2(pi,0)  --> 1/2*pi
atan2(-pi,0) -->  RuntimeError: power::eval(): division by zero
--------------------

sage-devel thread is here:

​http://groups.google.com/group/sage-devel/t/317e6bfe11fabb4

also reported on sage-support:

​http://groups.google.com/group/sage-support/t/02f3446e68381346

Attachments (1)

trac_8565-neg_pi.patch​ (1.5 KB) - added by burcin 12 years ago.
add doctests

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by burcin

add doctests

comment:1 Changed 12 years ago by burcin

  • Authors set to Burcin Erocal, Richard Kreckel, Jens Vollinga
  • Milestone set to sage-4.4
  • Status changed from new to needs_review

The pynac package at #8644 includes the patches that were merged in GiNaC to fix this problem. attachment:trac_8565-neg_pi.patch​ adds doctests for the fix.

This ticket now depends on #8644.

comment:2 Changed 12 years ago by robert.marik

  • Reviewers set to Robert Mařík
  • Status changed from needs_review to positive_review

Installs fine, all tests passed, works ad advertised. Positive review and thanks for fixing.

comment:3 Changed 12 years ago by was

  • Merged in set to 4.4.1.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:4 Changed 12 years ago by mvngu

  • Merged in changed from 4.4.1.alpha2 to sage-4.4.1.alpha2
Note: See TracTickets for help on using tickets.